Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram axis ranges #82

Closed
pat-s opened this issue Oct 4, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@pat-s
Copy link

commented Oct 4, 2018

Are hardcoded currently.

scale_x_continuous(labels = comma) +
scale_y_continuous(labels = comma) +

This leads to undesired behavior in histograms for variables with only 1 digit.

Given the fact that the ggplot objects are not returned, its not possible to change it. Looking forward to v0.7 :)

Reprex:

d = OpenML::getOMLDataSet(data.id = 61)
#> Downloading from 'http://www.openml.org/api/v1/data/61' to '/tmp/Rtmp1elTLE/cache/datasets/61/description.xml'.
#> Downloading from 'https://www.openml.org/data/v1/download/61/iris.arff' to '/tmp/Rtmp1elTLE/cache/datasets/61/dataset.arff'
#> Loading required package: readr

# convert the OpenML object to a tibble (enhanced data.frame)
iris = tibble::as_tibble(d)

DataExplorer::plot_histogram(iris, ggtheme = ggpubr::theme_pubr())

Created on 2018-10-04 by the reprex package (v0.2.1)

@boxuancui boxuancui self-assigned this Oct 5, 2018

@boxuancui boxuancui added the type: bug label Oct 5, 2018

@boxuancui boxuancui added this to the v0.7.0 milestone Oct 5, 2018

boxuancui added a commit that referenced this issue Oct 12, 2018

boxuancui added a commit that referenced this issue Oct 12, 2018

@boxuancui boxuancui closed this Oct 12, 2018

@boxuancui

This comment has been minimized.

Copy link
Owner

commented Oct 12, 2018

Removed almost all hard-coded scales from all plot functions.

@pat-s

This comment has been minimized.

Copy link
Author

commented Oct 12, 2018

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.