Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop zero-variance columns from PCA #130
Closed
Conversation
This will enable a workaround for the current pandoc conversion issue by excluding the script from the Rmd if the d3 plot is set to not render.
```
create_report(flights,
config = configure_report(
add_plot_str = FALSE
))
```
DataExplorer was yieldy a hard to diagnose error when there was columns with zero variance (e.g. nycflights13::flights$year). This change drops any zero variance columns from being included in the PCA analysis.
|
Thank you for doing this! It is really helpful! I will merge this whenever I have time (unit tests, etc.). |
|
Fixed #116 and added zero-variance handling. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I was encountering errors around d3 (#116 ) and the PCA erroring on the nycflight13 data which I tend to use as a more realistic example in my classes.
Makes d3 script inclusion dynamic
This will enable a workaround for the current pandoc conversion issue by excluding the script from the Rmd if the d3 plot is set to not render. This doesn't fix the full issue but offers a workaround.
Drop zero-var columns from PCA
DataExplorer was producing a hard to diagnose error when there were columns with zero variance (e.g. nycflights13::flights$year). This change drops any zero variance columns from being included in the PCA analysis.