Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC Settings bleeding through API #32

Closed
boyter opened this issue Sep 12, 2018 · 3 comments
Closed

GC Settings bleeding through API #32

boyter opened this issue Sep 12, 2018 · 3 comments
Assignees
@boyter
Labels
bug Something isn't working

Comments

@boyter
Copy link
Owner

boyter commented Sep 12, 2018

See https://github.com/pinpt/ripsrc/releases/tag/3.1.0

This should never have happened. Refactor so that this is only set via command line usage and not though API.

Also a big apology to @jhaynie for this.
@boyter boyter added the bug Something isn't working label Sep 12, 2018
@boyter boyter self-assigned this Sep 12, 2018
boyter added a commit that referenced this issue Sep 12, 2018
@boyter
Resolve bug #32
de0c4c8
@boyter
Copy link
Owner Author

boyter commented Sep 12, 2018

Once again sorry about the lost time @jhaynie I hope that the next release makes it up to you with what I am hoping is double the performance.

@boyter boyter closed this as completed Sep 12, 2018
@jhaynie
Copy link
Contributor

jhaynie commented Sep 13, 2018

No worries dude! Appreciate the fix. You’re doing AWESOME work

@boyter
Copy link
Owner Author

boyter commented Sep 13, 2018

Thanks for the kind words! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boyter boyter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhaynie @boyter