New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small cpu/mem optimizations #35

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@jhaynie
Copy link
Contributor

jhaynie commented Sep 14, 2018

don't run md5 hash for files that have duplicate turned off
don't create empty byte allocation for completion of the hash (nil suffices as termninator)
set file.content to nil instead of empty byte allocation to free memory in the end

small cpu/mem optimization to not run md5 hash for files that have du…
…plicate turned off

don't create empty byte allocation for completion of the hash (nil suffices as termninator)
set file.content to nil instead of empty byte allocation to free memory in the end
@boyter

This comment has been minimized.

Copy link
Owner

boyter commented Sep 14, 2018

Looks good. Nice pickups.

@boyter boyter merged commit 6319605 into boyter:master Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment