Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: bpaquet/log4node
base: 43657f36c0
...
head fork: bpaquet/log4node
compare: cce764bee1
Checking mergeability… Don't worry, you can still create the pull request.
  • 2 commits
  • 1 file changed
  • 0 commit comments
  • 2 contributors
Commits on Oct 09, 2012
Matthew Ratzloff Fix #16 - Remove the fs.exists check for handling USR2 signals
When running multiple processes that are writing to the same log
(not clustered), there is a race condition where the first process
to handle the signal will reopen the file handle (creating the
file), and all other processes will ignore the request because the
file already exists.  This fixes that issue.
e812463
Bertrand Paquet Merge pull request #17 from mratzloff/master
#16 Remove fs.exists check for reopen
cce764b
Showing with 1 addition and 5 deletions.
  1. +1 −5 lib/log4node.js
View
6 lib/log4node.js
@@ -69,11 +69,7 @@ function Log4Node(config) {
this.file = config.file;
this.reopen();
sig_listener.on('SIGUSR2', function() {
- fs.exists(this.file, function(exists) {
- if (!exists) {
- this.reopen();
- }
- }.bind(this));
+ this.reopen();
}.bind(this));
this.stream.on('error', function(err) {
console.warn('Unable to write into file : ' + this.file + ' ' + err);

No commit comments for this range

Something went wrong with that request. Please try again.