Permalink
Browse files

Sonar bug hunting: Parameter names

  • Loading branch information...
1 parent 0377c32 commit c36c4642df80f37035c8e7e7d98cef5593f99812 @dluebke dluebke committed May 15, 2012
View
4 ...unit/framework/coverage/annotation/metrics/branchcoverage/IStructuredActivityHandler.java
@@ -14,9 +14,9 @@
* Fügt Markierungen, die später durch Invoke-Aufrufe protokolliert werden,
* um die Ausführung der Zweige zu erfassen.
*
- * @param structured_activity
+ * @param structuredActivity
* @throws BpelException
*/
- public void insertBranchMarkers(Element structured_activity)
+ public void insertBranchMarkers(Element structuredActivity)
throws BpelException;
}
View
6 ...et/bpelunit/framework/coverage/annotation/metrics/branchcoverage/impl/ForEachHandler.java
@@ -30,12 +30,12 @@ public ForEachHandler(MarkersRegisterForArchive markersRegistry) {
* Fügt Markierungen, die später durch Invoke-Aufrufe protokolliert werden,
* um die Ausführung der Zweige zu erfassen.
*
- * @param forEach_activity
+ * @param forEachActivity
* @throws BpelException
*/
- public void insertBranchMarkers(Element forEach_activity)
+ public void insertBranchMarkers(Element forEachActivity)
throws BpelException {
- insertMarkerForSequenceBranches(forEach_activity);
+ insertMarkerForSequenceBranches(forEachActivity);
}
/**
View
8 ...ava/net/bpelunit/framework/coverage/annotation/metrics/branchcoverage/impl/IfHandler.java
@@ -72,18 +72,18 @@ private void insertMarkerForElseBranch(Element branchActivity)
/**
*
- * @param branch_activity
+ * @param branchActivity
* Aktivität aus dem ElseIf-Zweig.
* @throws BpelException
* Wenn keine Aktivität in dem Zweig vorhanden ist.
*/
- private void insertMarkerForElseIfBranches(Element branch_activity)
+ private void insertMarkerForElseIfBranches(Element branchActivity)
throws BpelException {
- if (branch_activity == null) {
+ if (branchActivity == null) {
throw new BpelException(BpelException.MISSING_REQUIRED_ACTIVITY);
}
- markersRegistry.registerMarker(BranchMetricHandler.insertLabelBevorAllActivities(branch_activity));
+ markersRegistry.registerMarker(BranchMetricHandler.insertLabelBevorAllActivities(branchActivity));
}
/**
View
8 ...a/net/bpelunit/framework/coverage/annotation/metrics/branchcoverage/impl/PickHandler.java
@@ -34,13 +34,13 @@ public PickHandler(MarkersRegisterForArchive markersRegistry) {
* Fügt Markierungen, die später durch Invoke-Aufrufe protokolliert werden,
* um die Ausführung der Zweige zu erfassen.
*
- * @param structured_activity
+ * @param structuredActivity
* @throws BpelException
*/
- public void insertBranchMarkers(Element structured_activity)
+ public void insertBranchMarkers(Element structuredActivity)
throws BpelException {
- identifyBranches(structured_activity, ON_MESSAGE);
- identifyBranches(structured_activity, ON_ALARM);
+ identifyBranches(structuredActivity, ON_MESSAGE);
+ identifyBranches(structuredActivity, ON_ALARM);
}
private void identifyBranches(Element element, String name)
View
8 ...pelunit/framework/coverage/annotation/metrics/branchcoverage/impl/RepeatUntilHandler.java
@@ -38,13 +38,13 @@ public RepeatUntilHandler(MarkersRegisterForArchive markersRegistry) {
* Fügt Markierungen, die später durch Invoke-Aufrufe protokolliert werden,
* um die Ausführung der Zweige zu erfassen.
*
- * @param structured_activity
+ * @param structuredActivity
* @throws BpelException
*/
- public void insertBranchMarkers(Element structured_activity)
+ public void insertBranchMarkers(Element structuredActivity)
throws BpelException {
- branchFromConditionToActivity(structured_activity);
- branchFromActivityToCondition(structured_activity);
+ branchFromConditionToActivity(structuredActivity);
+ branchFromActivityToCondition(structuredActivity);
}
private void branchFromActivityToCondition(Element element)
View
6 .../net/bpelunit/framework/coverage/annotation/metrics/branchcoverage/impl/WhileHandler.java
@@ -28,12 +28,12 @@ public WhileHandler(MarkersRegisterForArchive markersRegistry) {
* Fügt Markierungen, die später durch Invoke-Aufrufe protokolliert werden,
* um die Ausführung der Zweige zu erfassen.
*
- * @param structured_activity
+ * @param structuredActivity
* @throws BpelException
*/
- public void insertBranchMarkers(Element structured_activity)
+ public void insertBranchMarkers(Element structuredActivity)
throws BpelException {
- Element activity = getFirstEnclosedActivity(structured_activity);
+ Element activity = getFirstEnclosedActivity(structuredActivity);
if (activity == null)
throw new BpelException(BpelException.MISSING_REQUIRED_ACTIVITY);
View
6 .../bpelunit/framework/coverage/annotation/metrics/chcoverage/CompensationMetricHandler.java
@@ -43,13 +43,13 @@ public CompensationMetricHandler(MarkersRegisterForArchive markersRegistry) {
* danach entsprechende Invoke aufrufe generiert und dadurch die Ausführung
* bestimmter Aktivitäten geloggt.
*
- * @param process_elements
+ * @param processElements
* @throws BpelException
*/
- public void insertMarkersForMetric(List<Element> process_elements)
+ public void insertMarkersForMetric(List<Element> processElements)
throws BpelException {
Element handler;
- for (Iterator<Element> iter = process_elements.iterator(); iter.hasNext();) {
+ for (Iterator<Element> iter = processElements.iterator(); iter.hasNext();) {
handler = iter.next();
Element activity = getFirstEnclosedActivity(handler);
if (!activity.getName().equals(
View
22 ...va/net/bpelunit/framework/coverage/annotation/metrics/linkcoverage/LinkMetricHandler.java
@@ -134,12 +134,12 @@ private void createMarkerForLink2(Element link, Element sourceElement,
sourceActivity = sourceElement.getParentElement();
}
Element enclosedFlow = encloseElementInFlow(sourceActivity);
- Element new_link = insertPostivLink(enclosedFlow, sourceElement, link,
+ Element newLink = insertPostivLink(enclosedFlow, sourceElement, link,
transitionCondition);
- insertLoggingMarker(new_link, enclosedFlow, true);
- new_link = insertNegativLink(enclosedFlow, sourceElement, link,
+ insertLoggingMarker(newLink, enclosedFlow, true);
+ newLink = insertNegativLink(enclosedFlow, sourceElement, link,
transitionCondition);
- insertLoggingMarker(new_link, enclosedFlow, false);
+ insertLoggingMarker(newLink, enclosedFlow, false);
}
private String checkTransitionCondition(Element sourceElement) {
@@ -180,19 +180,19 @@ private Element searchSourceElement2(Element link, Element processElement) {
private Element insertPostivLink(Element flow, Element sourceElement,
Element link, String transitionCondition) {
Element linkCopy = createLinkCopy(link, flow, COPY_LINK_POSTFIX);
- Element new_source_element = createBPELElement(SOURCE_TAG);
- new_source_element.setAttribute(ATTRIBUTE_LINKNAME, linkCopy
+ Element newSourceElement = createBPELElement(SOURCE_TAG);
+ newSourceElement.setAttribute(ATTRIBUTE_LINKNAME, linkCopy
.getAttributeValue(ATTRIBUTE_NAME));
if (getProcessNamespace().equals(NAMESPACE_BPEL_2_0)) {
Element transConditionElement = (Element) sourceElement.getChild(
TRANSITION_CONDITION, getProcessNamespace()).clone();
- new_source_element.addContent((Element) transConditionElement
+ newSourceElement.addContent((Element) transConditionElement
.clone());
} else if (getProcessNamespace().equals(NAMESPACE_BPEL_1_1)) {
- new_source_element.setAttribute(TRANSITION_CONDITION,
+ newSourceElement.setAttribute(TRANSITION_CONDITION,
transitionCondition);
}
- sourceElement.getParentElement().addContent(0, new_source_element);
+ sourceElement.getParentElement().addContent(0, newSourceElement);
return linkCopy;
}
@@ -210,7 +210,7 @@ private Element createLinkCopy(Element link, Element flow, String postfix) {
return linkCopy;
}
- private void insertLoggingMarker(Element new_link, Element enclosedFlow,
+ private void insertLoggingMarker(Element newLink, Element enclosedFlow,
boolean isPositivValueOfLink) {
Comment logging;
@@ -228,7 +228,7 @@ private void insertLoggingMarker(Element new_link, Element enclosedFlow,
Element sequence = createSequence();
Element targetElement = createBPELElement(TARGET_TAG);
- targetElement.setAttribute(ATTRIBUTE_LINKNAME, new_link
+ targetElement.setAttribute(ATTRIBUTE_LINKNAME, newLink
.getAttributeValue(ATTRIBUTE_NAME));
if (getProcessNamespace().equals(NAMESPACE_BPEL_2_0)) {
Element targets = createBPELElement(TARGETS_TAG);
View
12 .../java/net/bpelunit/framework/coverage/annotation/tools/bpelxmltools/CMServiceFactory.java
@@ -55,16 +55,16 @@ private CMServiceFactory() {
/**
* F�gt Namespace und Partner Link f�r Coverage Logging Service.
*
- * @param process_element
+ * @param processElement
* Wurzelelement des BPEL-Prozesses.
*/
- public void prepareBPELFile(Element process_element) {
- process_element.addNamespaceDeclaration(COVERAGETOOL_NAMESPACE);
- insertPartnerLink(process_element);
+ public void prepareBPELFile(Element processElement) {
+ processElement.addNamespaceDeclaration(COVERAGETOOL_NAMESPACE);
+ insertPartnerLink(processElement);
}
- private void insertPartnerLink(Element process_element) {
- Element partnerLinks = process_element.getChild(PARTNERLINKS_ELEMENT,
+ private void insertPartnerLink(Element processElement) {
+ Element partnerLinks = processElement.getChild(PARTNERLINKS_ELEMENT,
getProcessNamespace());
Element partnerLink = createBPELElement(PARTNERLINK_ELEMENT);
partnerLink.setAttribute(NAME_ATTR, PARTNERLINK_NAME);

0 comments on commit c36c464

Please sign in to comment.