Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need stats for the current block height #1405

Closed
AndrejMitrovic opened this issue Dec 7, 2020 · 0 comments · Fixed by #1474
Closed

Need stats for the current block height #1405

AndrejMitrovic opened this issue Dec 7, 2020 · 0 comments · Fixed by #1474
Assignees
@Geod24
Labels
C. Monitoring Tools Related to CoinNet type-enhancement An improvement of existing functionalities
Milestone
5. CoinNet beta (...

Comments

@AndrejMitrovic
Copy link
Contributor

Currently we have stats such as agora_block_externalized_total:

https://github.com/bpfkorea/agora/blob/3402716cf39f69b31995ba205730bd189aa761ab/source/agora/node/Ledger.d#L257

However this is not very useful. It's only counting how many new blocks were externalized since the last time the node booted up. So if the node restarts this count will go to zero. It's much more useful to just show the actual current block height. That way if there's any discrepancies between the nodes we'll be able to easily see them (and graph them).
@AndrejMitrovic AndrejMitrovic added the type-enhancement An improvement of existing functionalities label Dec 7, 2020
@AndrejMitrovic AndrejMitrovic added this to the 5. CoinNet release milestone Dec 7, 2020
@kchulj kchulj added the C. Monitoring Tools Related to CoinNet label Dec 7, 2020
Geod24 added a commit to Geod24/agora that referenced this issue Jan 8, 2021
@Geod24
Add the absolute block height to the stats
62c17b8 
This is more useful than the number of block externalized since start.
Fixes bosagora#1405
@Geod24 Geod24 self-assigned this Jan 8, 2021
@Geod24 Geod24 mentioned this issue Jan 8, 2021
Merged
AndrejMitrovic pushed a commit that referenced this issue Jan 8, 2021
@Geod24 @AndrejMitrovic
Add the absolute block height to the stats
7370dce 
This is more useful than the number of block externalized since start.
Fixes #1405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Geod24 Geod24

Labels
C. Monitoring Tools Related to CoinNet type-enhancement An improvement of existing functionalities
Projects
None yet
Milestone
5. CoinNet beta (TestNet) agora Devel...
Development

Successfully merging a pull request may close this issue.

Add the absolute block height to the stats Geod24/agora
3 participants
@Geod24 @AndrejMitrovic @kchulj