Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrollment data should be written to the block. #493

Closed
TrustHenry opened this issue Jan 21, 2020 · 3 comments
Closed

Enrollment data should be written to the block. #493

TrustHenry opened this issue Jan 21, 2020 · 3 comments

Comments

@TrustHenry
Copy link
Member

@TrustHenry TrustHenry commented Jan 21, 2020

Writing Enrollment data to a block determines the height of the block that can participate in the validation as a validator.
Validators needed for the consensus process can be determined and the number of validators between nodes can be set.

Definition of Done:

  • The Enrollment data should be recorded only in the enroll start block.

  • When writing to a block, it must be sorted in ascending order by UTXOkey of the enrollment data.

  • The node store the enrolled block height.

How to implement

  • create a Query to import the elements from the Enrollment manager.

  • The conditions for this must be taken in order of the UTXOkey's ascending order with the null height of the block.

  • Record the target enrollments at block generation.

  • When the enrollment data is stored in a block, the height of that block must be renewed in the DB of the node.

@TrustHenry TrustHenry added this to the 2. Validator milestone Jan 21, 2020
@Geod24

This comment has been minimized.

Copy link
Member

@Geod24 Geod24 commented Jan 22, 2020

ascending order by UTXOkey

Do you mean ascending order of the hash, or something else (e.g. value) ?

@TrustHenry

This comment has been minimized.

Copy link
Member Author

@TrustHenry TrustHenry commented Jan 22, 2020

ascending order by UTXOkey

Do you mean ascending order of the hash, or something else (e.g. value) ?

That's right.
It is Enrollment.utxo_key or It's a utxo hash and a hash of index.

@bpalaggi bpalaggi moved this from To do to In progress (Max 5) in Sprint #10 (2020-01-21 to 2020-02-10) Jan 30, 2020
@bpalaggi bpalaggi moved this from In progress (Max 5) to Review/Testing (Max 2) in Sprint #10 (2020-01-21 to 2020-02-10) Feb 7, 2020
@bpalaggi bpalaggi removed this from Review/Testing (Max 2) in Sprint #10 (2020-01-21 to 2020-02-10) Feb 11, 2020
@bpalaggi bpalaggi added this to To do in Sprint #11 (2020-02-11 to 2020-02-24) via automation Feb 11, 2020
@bpalaggi bpalaggi moved this from To do to In progress (Max 5) in Sprint #11 (2020-02-11 to 2020-02-24) Feb 11, 2020
@bpalaggi bpalaggi moved this from In progress (Max 5) to Review/Testing (Max 2) in Sprint #11 (2020-02-11 to 2020-02-24) Feb 11, 2020
@bpalaggi bpalaggi moved this from Review/Testing (Max 2) to In progress (Max 5) in Sprint #11 (2020-02-11 to 2020-02-24) Feb 25, 2020
@bpalaggi bpalaggi moved this from In progress (Max 5) to Review/Testing (Max 2) in Sprint #11 (2020-02-11 to 2020-02-24) Feb 25, 2020
@bpalaggi bpalaggi added this to To do in Sprint #12 (2020-02-25 to 2020-03-9) via automation Feb 25, 2020
@bpalaggi bpalaggi removed this from Review/Testing (Max 2) in Sprint #11 (2020-02-11 to 2020-02-24) Feb 25, 2020
@bpalaggi bpalaggi moved this from To do to In progress (Max 5) in Sprint #12 (2020-02-25 to 2020-03-9) Feb 25, 2020
@bpalaggi bpalaggi moved this from In progress (Max 5) to Review/Testing (Max 2) in Sprint #12 (2020-02-25 to 2020-03-9) Feb 25, 2020
@Geod24 Geod24 closed this Mar 5, 2020
Sprint #12 (2020-02-25 to 2020-03-9) automation moved this from Review/Testing (Max 2) to Done Mar 5, 2020
@Geod24

This comment has been minimized.

Copy link
Member

@Geod24 Geod24 commented Mar 5, 2020

Done in #504 and some related PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.