Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Enrollment Part of Consensus #565

Closed
bpalaggi opened this issue Feb 20, 2020 · 1 comment
Closed

Make Enrollment Part of Consensus #565

bpalaggi opened this issue Feb 20, 2020 · 1 comment

Comments

@bpalaggi
Copy link

@bpalaggi bpalaggi commented Feb 20, 2020

Currently in the consensus protocol the nodes are reaching consensus on a set of transactions. However, now we have another data type which has to be placed in the block, the Enrollment.

The nodes need to reach consensus on Enrollments too, and not just transactions.

Therefore the Nominator needs to be changed.

Definition of Done:

  • Consensus should be made on a transaction set and any enrollments
  • If consensus is reached (externalized), create the block with the transaction set and the enrollments, and write it to the Ledger.

In the future this may be changed to vote on hashes instead, rather than passing around lots of data (Transaction data, Enrollment data). But this is a more complex task, so it should become its own issue.

@bpalaggi bpalaggi added this to the 2. Validator milestone Feb 20, 2020
@bpalaggi bpalaggi added this to To do in Sprint #11 (2020-02-11 to 2020-02-24) via automation Feb 21, 2020
@bpalaggi bpalaggi moved this from To do to Review/Testing (Max 2) in Sprint #11 (2020-02-11 to 2020-02-24) Feb 21, 2020
@bpalaggi bpalaggi added this to To do in Sprint #12 (2020-02-25 to 2020-03-9) via automation Feb 25, 2020
@bpalaggi bpalaggi removed this from Review/Testing (Max 2) in Sprint #11 (2020-02-11 to 2020-02-24) Feb 25, 2020
@bpalaggi bpalaggi moved this from To do to Review/Testing (Max 2) in Sprint #12 (2020-02-25 to 2020-03-9) Feb 25, 2020
@Geod24 Geod24 closed this Mar 5, 2020
Sprint #12 (2020-02-25 to 2020-03-9) automation moved this from Review/Testing (Max 2) to Done Mar 5, 2020
@Geod24

This comment has been minimized.

Copy link
Member

@Geod24 Geod24 commented Mar 5, 2020

Done in #620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.