Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be possible to re-enroll a Validator while it is in the validator set #824

Closed
AndrejMitrovic opened this issue May 13, 2020 · 0 comments · Fixed by #873
Closed

It should be possible to re-enroll a Validator while it is in the validator set #824

AndrejMitrovic opened this issue May 13, 2020 · 0 comments · Fixed by #873
Assignees
@linked0
Labels
prio-high Will have an effect in the next three sprints Story-Points:3 This takes 1 to 3 days to complete type-enhancement An improvement of existing functionalities
Milestone
2. Validator

Comments

@AndrejMitrovic
Copy link
Contributor

AndrejMitrovic commented May 13, 2020 •
edited

As discussed with @Geod24. This is similar to #822, but is a different feature.

Consider this case:

  • Genesis block begins with 2 validators
  • Their expiration block is at height 1008
  • At block height 1008 the validators want to re-enroll so they can begin validating blocks [1009 .. 2017]

Problem:
@AndrejMitrovic AndrejMitrovic added the type-enhancement An improvement of existing functionalities label May 13, 2020
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 15, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
9ccf964 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 15, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
56584cc 
This is a workaround for bosagora#824
@AndrejMitrovic AndrejMitrovic mentioned this issue May 15, 2020
Merged
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 15, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
d9cfcbf 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 18, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
a222188 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 18, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
72d34e6 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 18, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
309b12f 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 18, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
ac3220d 
This is a workaround for bosagora#824
@Geod24 Geod24 added the prio-high Will have an effect in the next three sprints label May 19, 2020
@Geod24 Geod24 added this to the 2. Validator milestone May 19, 2020
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 19, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
256c275 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 19, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
a2049de 
This is a workaround for bosagora#824
@bpalaggi bpalaggi added the Story-Points:3 This takes 1 to 3 days to complete label May 20, 2020
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 20, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
c02c521 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 20, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
aa123f9 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 20, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
9ad8be4 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 20, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
3c9b694 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 20, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
8cca16b 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 21, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
494aba2 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 25, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
0d8f4ba 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 25, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
d972859 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 25, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
678ec8d 
This is a workaround for bosagora#824
linked0 added a commit to linked0/agora that referenced this issue May 25, 2020
@linked0
The validator set add an enrollment before the cycle
f18b05b 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue May 26, 2020
@linked0
The validator set add an enrollment before the cycle
3c5febc 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
@linked0 linked0 mentioned this issue May 26, 2020
Merged
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 26, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
e3ce0b1 
This is a workaround for bosagora#824
linked0 added a commit to linked0/agora that referenced this issue May 26, 2020
@linked0
The validator set add an enrollment before the cycle
3cde585 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 26, 2020
@AndrejMitrovic
Allow re-enrolling validators if they're enrolled
333cfdc 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 27, 2020
@AndrejMitrovic
[Workaround] Allow re-enrolling validators if they're enrolled
535590c 
This is a workaround for bosagora#824
linked0 added a commit to linked0/agora that referenced this issue May 28, 2020
@linked0
The validator set add an enrollment before the cycle
b87d69d 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue May 28, 2020
@linked0
The validator set add an enrollment before the cycle
e2c0f13 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 29, 2020
@AndrejMitrovic
[Workaround] Allow re-enrolling validators if they're enrolled
28fed0a 
This is a workaround for bosagora#824
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue May 29, 2020
@AndrejMitrovic
[Workaround] Allow re-enrolling validators if they're enrolled
f3834ce 
This is a workaround for bosagora#824
This was referenced May 31, 2020
Closed
Merged
AndrejMitrovic added a commit to AndrejMitrovic/agora that referenced this issue Jun 1, 2020
@AndrejMitrovic
[Workaround] Allow re-enrolling validators if they're enrolled
63be144 
This is a workaround for bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 1, 2020
@linked0
The validator set add an enrollment before the cycle
cc605a9 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
@Geod24 Geod24 linked a pull request Jun 2, 2020 that will close this issue
EnrollmentManager add an enrollment before the cycle #873
Merged
linked0 added a commit to linked0/agora that referenced this issue Jun 2, 2020
@linked0
The validator set add an enrollment before the cycle
e93c0a4 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 2, 2020
@linked0
The validator set add an enrollment before the cycle
fd0ced1 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 2, 2020
@linked0
The validator set add an enrollment before the cycle
76a5c1c 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 2, 2020
@linked0
The validator set add an enrollment before the cycle
514b4de 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 3, 2020
@linked0
The validator set add an enrollment before the cycle
9e00bb2 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 3, 2020
@linked0
The validator set add an enrollment before the cycle
5da798a 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 11, 2020
@linked0
The validator set add an enrollment before the cycle
f0ef082 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 12, 2020
@linked0
The validator set add an enrollment before the cycle
931603f 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 19, 2020
@linked0
The validator set add an enrollment before the cycle
a65bbf7 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 22, 2020
@linked0
The validator set add an enrollment before the cycle
1799533 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 23, 2020
@linked0
The validator set add an enrollment before the cycle
db7e4a1 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 23, 2020
@linked0
The validator set add an enrollment before the cycle
a8fa054 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 23, 2020
@linked0
The validator set add an enrollment before the cycle
52a3db9 
The validator set should allow a node to re-enroll before the validator cycle
ends. It's not for sure that an enrollment will be contained in the next
new block, so the validator set must add the enrollment earlier before the
cycle ends.

I added the constant about the round that a node can re-enroll because
unnecessary re-enrollments should be avoid. The value can be configurable.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 23, 2020
@linked0
The EnrollmentManager add enrollments before the cycle
9892c72 
The `EnrollmentManager` should allow a node to re-enroll before the validator cycle
ends. If requests for enrolllment arrives before the cycle ends, the
enrollment will be added in the height where the cycle ends. So the
`getEnrollments` of the `EnrollmentManager` must return the enrollments right
before the end of the cycle.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 23, 2020
@linked0
The EnrollmentManager add enrollments before the cycle
bf25c12 
The `EnrollmentManager` should allow a node to re-enroll before the validator cycle
ends. If requests for enrolllment arrives before the cycle ends, the
enrollment will be added in the height where the cycle ends. So the
`getEnrollments` of the `EnrollmentManager` must return the enrollments right
before the end of the cycle.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 23, 2020
@linked0
The EnrollmentManager add enrollments before the cycle
37fa12a 
The `EnrollmentManager` should allow a node to re-enroll before the validator cycle
ends. If requests for enrolllment arrives before the cycle ends, the
enrollment will be added in the height where the cycle ends. So the
`getEnrollments` of the `EnrollmentManager` must return the enrollments right
before the end of the cycle.

Relates bosagora#824
linked0 added a commit to linked0/agora that referenced this issue Jun 24, 2020
@linked0
The EnrollmentManager add enrollments before the cycle
f499858 
The `EnrollmentManager` should allow a node to re-enroll before the validator cycle
ends. If requests for enrolllment arrives before the cycle ends, the
enrollment will be added in the height where the cycle ends. So the
`getEnrollments` of the `EnrollmentManager` must return the enrollments right
before the end of the cycle.

Relates bosagora#824
Geod24 pushed a commit that referenced this issue Jun 24, 2020
@linked0 @Geod24
The EnrollmentManager add enrollments before the cycle
b085758 
The `EnrollmentManager` should allow a node to re-enroll before the validator cycle
ends. If requests for enrolllment arrives before the cycle ends, the
enrollment will be added in the height where the cycle ends. So the
`getEnrollments` of the `EnrollmentManager` must return the enrollments right
before the end of the cycle.

Relates #824
@linked0 linked0 mentioned this issue Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@linked0 linked0

Labels
prio-high Will have an effect in the next three sprints Story-Points:3 This takes 1 to 3 days to complete type-enhancement An improvement of existing functionalities
Projects
None yet
Milestone
2. Validator
Development

Successfully merging a pull request may close this issue.

EnrollmentManager add an enrollment before the cycle linked0/agora
4 participants
@Geod24 @linked0 @AndrejMitrovic @bpalaggi