Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit module name when a test fails #439

Merged
merged 1 commit into from Dec 2, 2019

Conversation

@AndrejMitrovic
Copy link
Member

AndrejMitrovic commented Dec 2, 2019

Sometimes the stack trace doesn't show the
origin of the module for which the tests ran.

Now the name of the failing module is shown.

Sometimes the stack trace doesn't show the
origin of the module for which the tests ran.

Now the name of the failing module is shown.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #439 into v0.x.x will decrease coverage by 1.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x     #439      +/-   ##
==========================================
- Coverage    87.3%   85.76%   -1.55%     
==========================================
  Files          53       52       -1     
  Lines        3593     3568      -25     
==========================================
- Hits         3137     3060      -77     
- Misses        456      508      +52
Flag Coverage Δ
#integration ?
#unittests 85.76% <0%> (-0.06%) ⬇️
Impacted Files Coverage Δ
source/agora/test/Base.d 83.91% <0%> (-1.3%) ⬇️
source/agora/common/Task.d 0% <0%> (-100%) ⬇️
source/agora/common/Config.d 61.24% <0%> (-27.91%) ⬇️
source/agora/node/Node.d 82.85% <0%> (-14.37%) ⬇️
source/agora/common/crypto/Key.d 82.97% <0%> (-5.32%) ⬇️
source/agora/network/NetworkManager.d 69.56% <0%> (-5.08%) ⬇️
source/agora/node/BlockStorage.d 67.87% <0%> (-0.73%) ⬇️
source/agora/node/main.d

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4badd0f...67cbdfe. Read the comment docs.

@Geod24
Geod24 approved these changes Dec 2, 2019
@Geod24 Geod24 merged commit de09825 into bpfkorea:v0.x.x Dec 2, 2019
12 checks passed
12 checks passed
MacOS (macOS-latest, dmd-2.089.0)
Details
MacOS (macOS-latest, dmd-2.088.1)
Details
MacOS (macOS-latest, dmd-master)
Details
Linux (ubuntu-latest, dmd-2.089.0)
Details
Linux (ubuntu-latest, dmd-2.088.1)
Details
Linux (ubuntu-latest, ldc-1.18.0)
Details
Linux (ubuntu-latest, ldc-1.17.0)
Details
Linux (ubuntu-latest, dmd-master)
Details
Linux (ubuntu-latest, ldc-master)
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
@AndrejMitrovic AndrejMitrovic deleted the AndrejMitrovic:show-failed-module branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.