Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[De]Serializer: Support BitBlob of any size + small cleanup #442

merged 3 commits into from Dec 3, 2019


Copy link

Geod24 commented Dec 3, 2019

Better reviewed commit-by-commit.

Those methods are only performing the default serialization,
so they can be safely removed.
Geod24 added 2 commits Dec 3, 2019
Since BitBlob is a value type, it needs to be handled explicitly.
Relying on the default rules would mean the `opIndex` gets called,
which leads to the length (which is fixed) to be serialized.
Those methods are only performing the default serialization,
so they can be safely removed.

This comment has been minimized.

Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #442 into v0.x.x will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x     #442      +/-   ##
+ Coverage   87.33%   87.37%   +0.04%     
  Files          53       53              
  Lines        3616     3620       +4     
+ Hits         3158     3163       +5     
+ Misses        458      457       -1
Flag Coverage Δ
#integration 55.38% <100%> (-0.01%) ⬇️
#unittests 85.89% <100%> (+0.04%) ⬆️
Impacted Files Coverage Δ
source/agora/common/crypto/Schnorr.d 100% <ø> (ø) ⬆️
source/agora/common/Serializer.d 98.61% <100%> (+1.5%) ⬆️
source/agora/common/Deserializer.d 91.13% <100%> (+0.47%) ⬆️
source/agora/common/Amount.d 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4e3d0e...300a59f. Read the comment docs.

@Geod24 Geod24 force-pushed the Geod24:serialize-method branch from 17b6327 to 300a59f Dec 3, 2019
@TrustHenry TrustHenry merged commit 0bcd88e into bpfkorea:v0.x.x Dec 3, 2019
12 checks passed
12 checks passed
MacOS (macOS-latest, dmd-2.089.0)
MacOS (macOS-latest, dmd-2.088.1)
MacOS (macOS-latest, dmd-master)
Linux (ubuntu-latest, dmd-2.089.0)
Linux (ubuntu-latest, dmd-2.088.1)
Linux (ubuntu-latest, ldc-1.18.0)
Linux (ubuntu-latest, ldc-1.17.0)
Linux (ubuntu-latest, dmd-master)
Linux (ubuntu-latest, ldc-master)
Travis CI - Pull Request Build Passed
ci/circleci: build Your tests passed on CircleCI!
ci/dockercloud Your tests passed in Docker Cloud
@Geod24 Geod24 deleted the Geod24:serialize-method branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.