Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit reason a Transaction was rejected to the log #450

Merged
merged 1 commit into from Dec 20, 2019

Conversation

@AndrejMitrovic
Copy link
Member

AndrejMitrovic commented Dec 13, 2019

Something I've noticed during debugging was a lack of information about rejected transactions.

@AndrejMitrovic AndrejMitrovic changed the title Emit reason a tx was rejected to the log Emit reason a Transaction was rejected to the log Dec 13, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #450 into v0.x.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x     #450      +/-   ##
==========================================
+ Coverage   87.59%   87.59%   +<.01%     
==========================================
  Files          54       54              
  Lines        3699     3700       +1     
==========================================
+ Hits         3240     3241       +1     
  Misses        459      459
Flag Coverage Δ
#integration 53.27% <100%> (ø) ⬆️
#unittests 86.14% <100%> (ø) ⬆️
Impacted Files Coverage Δ
source/agora/node/Ledger.d 96.18% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd36125...b7f7dde. Read the comment docs.

@AndrejMitrovic AndrejMitrovic force-pushed the AndrejMitrovic:better-tx-errors branch from b005af9 to 40816ec Dec 16, 2019
Also remove the isValidTransaction() function
as it was only used in one place.
@Geod24 Geod24 force-pushed the AndrejMitrovic:better-tx-errors branch from 40816ec to b7f7dde Dec 19, 2019
@Geod24

This comment has been minimized.

Copy link
Member

Geod24 commented Dec 19, 2019

Rebased on v0.x.x to trigger the CI.

@Geod24
Geod24 approved these changes Dec 19, 2019
@Geod24 Geod24 merged commit 3c60b05 into bpfkorea:v0.x.x Dec 20, 2019
9 checks passed
9 checks passed
MacOS (macOS-latest, dmd-2.089.1)
Details
MacOS (macOS-latest, dmd-master)
Details
Linux (ubuntu-latest, dmd-2.089.1)
Details
Linux (ubuntu-latest, ldc-1.18.0)
Details
Linux (ubuntu-latest, dmd-master)
Details
Linux (ubuntu-latest, ldc-master)
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.