Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make makeNewBlock() nothrow #452

Merged
merged 1 commit into from Dec 19, 2019
Merged

Make makeNewBlock() nothrow #452

merged 1 commit into from Dec 19, 2019

Conversation

@AndrejMitrovic
Copy link
Member

AndrejMitrovic commented Dec 17, 2019

No description provided.

@TrustHenry

This comment has been minimized.

Copy link
Member

TrustHenry commented Dec 17, 2019

What does this enhancement for?

@AndrejMitrovic

This comment has been minimized.

Copy link
Member Author

AndrejMitrovic commented Dec 17, 2019

It enables marking other functions nothrow which use this function. While testing I got an error that makeNewBlock was not nothrow, but realized it can be nothrow.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #452 into v0.x.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v0.x.x     #452   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          54       54           
  Lines        3699     3699           
=======================================
  Hits         3240     3240           
  Misses        459      459
Flag Coverage Δ
#integration 53.33% <ø> (+0.06%) ⬆️
#unittests 86.14% <ø> (ø) ⬆️
Impacted Files Coverage Δ
source/agora/consensus/data/Block.d 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd36125...b849390. Read the comment docs.

@Geod24
Geod24 approved these changes Dec 17, 2019
@Geod24 Geod24 force-pushed the AndrejMitrovic:nothrow branch from 457c9bc to b849390 Dec 19, 2019
@Geod24

This comment has been minimized.

Copy link
Member

Geod24 commented Dec 19, 2019

Rebased on v0.x.x to fix the CI

@Geod24 Geod24 merged commit ee08f36 into bpfkorea:v0.x.x Dec 19, 2019
9 checks passed
9 checks passed
MacOS (macOS-latest, dmd-2.089.1)
Details
MacOS (macOS-latest, dmd-master)
Details
Linux (ubuntu-latest, dmd-2.089.1)
Details
Linux (ubuntu-latest, ldc-1.18.0)
Details
Linux (ubuntu-latest, dmd-master)
Details
Linux (ubuntu-latest, ldc-master)
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
@AndrejMitrovic AndrejMitrovic deleted the AndrejMitrovic:nothrow branch Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.