Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenSSL linking on OSX & update vibe-core to v1.8.1 #453

Merged
merged 3 commits into from Dec 19, 2019

Conversation

@Geod24
Copy link
Member

Geod24 commented Dec 17, 2019

Each commits fix a separate issue with the CI.
The first issue fixes Travis on OSX, which currently can't link.
The second fixes the documentation deployment.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #453 into v0.x.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           v0.x.x     #453   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          54       54           
  Lines        3699     3699           
=======================================
  Hits         3240     3240           
  Misses        459      459
Flag Coverage Δ
#integration 53.27% <ø> (-0.07%) ⬇️
#unittests 86.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bef9a...7731016. Read the comment docs.

Geod24 added 2 commits Dec 17, 2019
This fixes our documentation build
Since openssl1.1 conflicts with the system's 'openssl' binary,
it is not automatically linked (available to pkg-config & co).
@Geod24 Geod24 force-pushed the Geod24:fix-docs branch from 3ecec0c to 4e2f81d Dec 19, 2019
@Geod24 Geod24 changed the title Update vibe-core to v1.8.1 Fix OpenSSL linking on OSX & update vibe-core to v1.8.1 Dec 19, 2019
@Geod24

This comment has been minimized.

Copy link
Member Author

Geod24 commented Dec 19, 2019

For context:

  • This include a submodule update which is just the this PR on top of our current Vibe.d;
  • I'm also seeing the issue of dub being broken. Here's an explanation why. I'll commit a workaround soon.
@Geod24 Geod24 force-pushed the Geod24:fix-docs branch from 280e60f to f3c75a6 Dec 19, 2019
It seems that currently DUB suffers from a druntime regression,
so this should help with the random segfaults in the CI.
After investigation, it might be originating from the parallel
marking done by the GC.

However, due to a discrepancy in 'install.sh', the 'dub' that can
be directly installed is compiled with an older compiler than the
one bundled with DMD 2.089.1, and this older compiler does not
support parallel marking.

However, this older compiler also does not have the correct code
to support TLS data on Mac OSX 10.15, hence why the matrix is split.
The parallel marking bug does not seem to manifest on OSX.
@Geod24 Geod24 force-pushed the Geod24:fix-docs branch from f3c75a6 to 7731016 Dec 19, 2019
@Geod24

This comment has been minimized.

Copy link
Member Author

Geod24 commented Dec 19, 2019

Self merging to unblock other PRs

@Geod24 Geod24 merged commit dd36125 into bpfkorea:v0.x.x Dec 19, 2019
9 checks passed
9 checks passed
MacOS (macOS-latest, dmd-2.089.1)
Details
MacOS (macOS-latest, dmd-master)
Details
Linux (ubuntu-latest, dmd-2.089.1)
Details
Linux (ubuntu-latest, ldc-1.18.0)
Details
Linux (ubuntu-latest, dmd-master)
Details
Linux (ubuntu-latest, ldc-master)
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
@Geod24 Geod24 deleted the Geod24:fix-docs branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.