Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the secretKeyToCurveScalar function #455

Merged
merged 1 commit into from Dec 30, 2019
Merged

Conversation

@linked0
Copy link
Contributor

linked0 commented Dec 30, 2019

The private key of a KeyPair object is converted to the 'v' variable of a Pair structure by using the function in the middle of making a enrollment data.

#406

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #455 into v0.x.x will decrease coverage by 1.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x     #455      +/-   ##
==========================================
- Coverage   87.63%   86.19%   -1.44%     
==========================================
  Files          54       53       -1     
  Lines        3727     3701      -26     
==========================================
- Hits         3266     3190      -76     
- Misses        461      511      +50
Flag Coverage Δ
#integration ?
#unittests 86.19% <100%> (ø) ⬆️
Impacted Files Coverage Δ
source/agora/common/EnrollmentManager.d 97.4% <100%> (ø) ⬆️
source/agora/common/Task.d 0% <0%> (-100%) ⬇️
source/agora/common/Config.d 61.24% <0%> (-27.91%) ⬇️
source/agora/node/Node.d 82.85% <0%> (-14.37%) ⬇️
source/agora/network/NetworkManager.d 69.56% <0%> (-5.08%) ⬇️
source/agora/common/crypto/Key.d 84.25% <0%> (-4.63%) ⬇️
source/agora/node/BlockStorage.d 67.87% <0%> (-0.73%) ⬇️
source/agora/node/main.d

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989041a...07a5678. Read the comment docs.

The private key of a KeyPair object is converted to the 'v' variable of a Pair structure by using the function in the middle of making a enrollment data.
@linked0 linked0 force-pushed the linked0:apply-henry branch from 1bdf143 to 07a5678 Dec 30, 2019
@linked0

This comment has been minimized.

Copy link
Contributor Author

linked0 commented Dec 30, 2019

Ready for review.

@Geod24
Geod24 approved these changes Dec 30, 2019
@Geod24 Geod24 merged commit 0288a57 into bpfkorea:v0.x.x Dec 30, 2019
5 of 9 checks passed
5 of 9 checks passed
MacOS (macOS-latest, dmd-2.089.1)
Details
MacOS (macOS-latest, dmd-master)
Details
Linux (ubuntu-latest, dmd-2.089.1) Linux (ubuntu-latest, dmd-2.089.1)
Details
Linux (ubuntu-latest, ldc-1.18.0) Linux (ubuntu-latest, ldc-1.18.0)
Details
Linux (ubuntu-latest, dmd-master) Linux (ubuntu-latest, dmd-master)
Details
Linux (ubuntu-latest, ldc-master) Linux (ubuntu-latest, ldc-master)
Details
Travis CI - Pull Request Build Passed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/dockercloud Your tests passed in Docker Cloud
Details
@Geod24

This comment has been minimized.

Copy link
Member

Geod24 commented Dec 30, 2019

Can someone make a PR to temporarily disable ldc-master testing ? It's a bit hard for me, given my internet restrictions ATM :)

@Geod24

This comment has been minimized.

Copy link
Member

Geod24 commented Dec 30, 2019

Actually, we only need to update the action to v0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.