fix(vm): re-use ide, sata, and scsi cloud-init storage (#1083)

[michaelfranzl]

Contributor's Note

• I have added / updated documentation in /docs for any user-facing features or additions.
• I have added / updated templates in /example for any new or updated resources / data sources.
• I have ran make example to verify that the change works as expected.

I'm a first-time contributor, so this PR might not be acceptable, but I'd appreciate if you'd help me along.

Proof of Work

I have manually tested the described use case of #1083 against Proxmox, and found it working.

TODO: Automatic testing: Write an example targeting this use case.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1083

[bpg-dev]

Hi @michaelfranzl 👋🏼

Thanks a lot for the PR! I really appreciate contributions! ❤️
I'll take a closer look a bit later in the week, we could probably simplify a few things there. As you mentioned, it would be nice to have this use case captured in the acceptance tests, i may be able to quickly add them as well.

In a meantime, would you mind signing DCO? You can find more information in Details of the failed DCO check.

[michaelfranzl]

I'll sign the DCO, and see if I can add acceptance tests as well.

[michaelfranzl]

@bpg In the first commit, I added a failing acceptance test. The failing test output is:

=== RUN   TestAccResourceVMInitialization                                                                 
=== RUN   TestAccResourceVMInitialization/initialization                                                  
    resource_vm_test.go:184: Step 1/1 error: After applying this test step, the non-refresh plan was not empty.                                                                                                     
        stdout:                                                                                           
                                                                                                          
                                                                                                          
        Terraform used the selected providers to generate the following execution                                                                                                                                   
        plan. Resource actions are indicated with the following symbols:                                                                                                                                            
          ~ update in-place                                                                               
                                                                                                          
        Terraform will perform the following actions:                                                     
                                                                                                          
          # proxmox_virtual_environment_vm.test_vm_network1 will be updated in-place                                                                                                                                
          ~ resource "proxmox_virtual_environment_vm" "test_vm_network1" {                                                                                                                                          
                id                      = "100"                                                           
                # (26 unchanged attributes hidden)                                                        
                                                                                                          
              ~ cpu {                                                                                     
                  + flags        = []                                                                     
                    # (8 unchanged attributes hidden)                                                     
                }                                                                                         
                                                                                                          
              ~ initialization {                                                                          
                  + datastore_id      = "local-lvm"                                                       
                  + interface         = "scsi1"                                                           
                    # (1 unchanged attribute hidden)                                                      
                                                                                                          
                    # (1 unchanged block hidden)                                                          
                }                                                                                         
                                                                                                          
                # (4 unchanged blocks hidden)                                                             
            }                                                                                             
                                                                                                          
        Plan: 0 to add, 1 to change, 0 to destroy.                                                        
--- FAIL: TestAccResourceVMInitialization (57.05s)                                                        
    --- FAIL: TestAccResourceVMInitialization/initialization (57.05s)                                                                                                                                               
FAIL                                                                                                      
FAIL    github.com/bpg/terraform-provider-proxmox/fwprovider/tests      57.052s                                                                                                                                     
FAIL

This output exactly reproduces what is reported in #1083.

The test then passes with the second commit, which only modifies the implementation.

[bpg-dev]

Awesome work, much appreciated!

LGTM! 🚀

[bpg-dev]

@all-contributors please add @michaelfranzl for code, test

[allcontributors]

@bpg

I've put up a pull request to add @michaelfranzl! 🎉