Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background does not cover full height on long pages #70

Closed
Potherca opened this issue Apr 3, 2023 · 3 comments
Closed

Background does not cover full height on long pages #70

Potherca opened this issue Apr 3, 2023 · 3 comments

Comments

@Potherca
Copy link
Member

Potherca commented Apr 3, 2023

The latest changes for full-height on smaller content has caused full-height to break on longer content.

This is caused because the height is set to 100% but the page is longer than 100%.

image

Setting the min-height to 100% would fix this for long pages but break for short pages

image

The solution would be to set both height and min-height on the body but only min-height on #page:

body {
    min-height: 100%;
    height: 100%;
}

#page {
    min-height: 100%;
}

I don't have time to fix the code right now, if nobody else picks this up, I'll come back to it later.

@samlikins
Copy link
Member

samlikins commented Apr 3, 2023

@Potherca, you're absolutely correct, good catch. I didn't notice that issue, the problem didn't seem to show on my local preview for longer pages. Updates have been made.

@samlikins
Copy link
Member

PR #71, compared, merged, and closed.

@Potherca
Copy link
Member Author

Potherca commented Apr 3, 2023

@samlikins No worries! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants