Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Rack Middleware breaks RSpec integration tests #16

Merged
merged 1 commit into from Jun 11, 2012

Conversation

Projects
None yet
2 participants
Contributor

azach commented Jun 8, 2012

Using versionist with a header breaks most of our integration tests since the HTTP_ACCEPT header isn't set. In most cases, we can pass in the HTTP_ACCEPT manually, but this shouldn't be necessary since most tests don't require a specific value to be set.

Owner

bploetz commented Jun 9, 2012

Thanks for this. Can you please add a test for this as well?

Contributor

azach commented Jun 11, 2012

Yep, absolutely! Test added.

@bploetz bploetz merged commit 3d66152 into bploetz:master Jun 11, 2012

Owner

bploetz commented Jun 11, 2012

Versionist 0.2.1 has been pushed out with this fix. Give it a whirl and let me know if you see any issues.

Thanks again.

Contributor

azach commented Jun 11, 2012

Working great, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment