Add subprocess with start event included #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavjf
added
needs discussion
nikku
added
needs review
gustavjf
force-pushed
the
add-subprocess-with-start-event-included
branch
from
9e0fb1d
to
af2c22d
Compare
gustavjf
force-pushed
the
add-subprocess-with-start-event-included
branch
2 times, most recently
from
81607d2
to
d35dbce
Compare
|
Looks good. |
gustavjf
force-pushed
the
add-subprocess-with-start-event-included
branch
from
d35dbce
to
aff8315
Compare
gustavjf
changed the title
nikku
reviewed
May 29, 2019
| var shape = event.context.shape, | ||
| hints = event.context.hints; | ||
|
|
||
| if ( |
There was a problem hiding this comment.
Shouldn't this be something like hints.shouldAddStartEvent = is('subporcess') && isExpanded(shape)?
That piece of code will set shouldaddStartEvent for every task.
There was a problem hiding this comment.
Good point, that simplifies things.
When: 1. Creating expanded subprocess from palette. 2. Replacing task with expanded subprocess.
gustavjf
force-pushed
the
add-subprocess-with-start-event-included
branch
from
aff8315
to
ff31bfe
Compare
delete-merged-branch
bot
deleted the
add-subprocess-with-start-event-included
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Related to camunda/camunda-modeler#1242
Dependent on bpmn-io/diagram-js#347
This automatically adds a start event to an expanded subprocess when: