Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): add source and target for example connection #327

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@pinussilvestrus
Copy link
Contributor

commented May 2, 2019

It seems that the example leads to confusion in some place since when moving one of the shapes (visually) connected by the example connection, the connection didn't get updated (cf. forum thread):

May-02-2019 09-33-12

This is correct by design since the connection didn't get a target nor a source on creation. This pull request adds it to avoid confusion.

May-02-2019 09-36-11

@ghost ghost assigned pinussilvestrus May 2, 2019

@ghost ghost added the needs review label May 2, 2019

@pinussilvestrus pinussilvestrus requested a review from barmac May 2, 2019

@pinussilvestrus

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

If you think this is expected behavior, we could just leave it is at it is. In my opinion, it just confuses people, since newly created connection via the example ContextPad automatically align correctly, but the manually created doesn't.

@barmac

barmac approved these changes May 2, 2019

Copy link
Member

left a comment

Good job!

@merge-me merge-me bot merged commit 38ec1b1 into master May 2, 2019

5 checks passed

WIP Ready for review
Details
codecov/patch Coverage not affected when comparing ffca1cf...5f64a77
Details
codecov/project 91.9% remains the same compared to ffca1cf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the update-example branch May 2, 2019

@ghost ghost removed the needs review label May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.