chore(CHANGELOG): update with breaking change #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snapping seems to be another breaking change:
|
|
In diagram-js we've introduced a large number of additional snap points secretly via 8469f3c. We got to decide whether to undo that change (and give toolkit consumers more fine grained control) or market that as a feature. |
|
@nikku No test failures in dmn-js after |
|
So it seems like the only breaking bit is the additional snap points that I propose to unbuild (cf. bpmn-io/bpmn-js#1104). Thanks for investigating. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed the reason why it's going to be a major version. This PR adds the breaking change to the changelog.