Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(object#set): enforce key types #21

Merged
merged 1 commit into from
Jan 17, 2022
Merged

fix(object#set): enforce key types #21

merged 1 commit into from
Jan 17, 2022

Conversation

marstamm
Copy link
Contributor

This also fixes the prototype pollution through set({}, [["__proto__"], "polluted"], "success")

@marstamm marstamm requested review from barmac, a team and pinussilvestrus and removed request for a team January 17, 2022 11:42
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 17, 2022
@fake-join fake-join bot merged commit 2c6689e into master Jan 17, 2022
@fake-join fake-join bot deleted the enforce-key-types branch January 17, 2022 11:52
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus pinussilvestrus was automatically assigned from bpmn-io/modeling-dev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marstamm @barmac