Wrong peer_name #3

Open
tsouza opened this Issue Jan 3, 2013 · 1 comment

2 participants

@tsouza

Hello,

It seems that peer_name is wrong when ip_to_bind is passed.

At gossiper.js:35 shouldn't it be? (as there is no address property)

this.peer_name    = [this.ip_to_bind, this.port.toString()].join(':');

Cheers

@snoj

I've just assigned the address property manually when specifying an ip to bind to.

var Gossiper = require('./node-gossip/index.js').Gossiper
var g = new Gossiper(9000, [], '192.168.1.1');
g.address = '8.8.8.8';
g.start();

The code does seem to assume that whatever you're binding to can be routed to from any peers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment