Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

Pricing per country #80

Closed
boryn opened this issue Jun 17, 2021 · 3 comments · Fixed by #119
Closed

Pricing per country #80

boryn opened this issue Jun 17, 2021 · 3 comments · Fixed by #119
Labels
enhancement New feature or request
Milestone

Comments

@boryn
Copy link
Contributor

boryn commented Jun 17, 2021

I know there is currency field but sometimes it's necessary to define the prices not only per currency but also per country. For example different pricing schema among different countries in the euro zone. Or just different pricing across different countries.

I'd see additional field country in the plans table which would allow creating pricing plans per country. I know one could use a special naming for tags, for example "basic-usd-us", "basic-gbp-uk", "pro-usd-us", "pro-gbp-uk", etc. but filtering such plans is a pure pain. With additional scope, filtering by country would be very easy.

Or if not with country specifically, maybe we could just go with a more generic filed name, like group?

I see this change necessary only in plans, it does not need to be copied to plan_subscriptions.

@bpuig bpuig added the enhancement New feature or request label Jun 17, 2021
@stale
Copy link

stale bot commented Aug 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 16, 2021
@boryn
Copy link
Contributor Author

boryn commented Aug 25, 2021

Hi @bpuig! What do you think about adding this extra field? I work on another project where again it would be useful as there is a need to have a different pricings per country.

@stale stale bot removed the wontfix This will not be worked on label Aug 25, 2021
@bpuig bpuig added this to v6 in Laravel Subby Sep 5, 2021
@bpuig bpuig added this to the v6.0.0 milestone Sep 5, 2021
@boryn
Copy link
Contributor Author

boryn commented Sep 10, 2021

Couldn't this extra column be added yet in v5? It seems very easy to extend the migration just by this column. I was about to extend my own model but it'd be better to have this in the library.

@bpuig bpuig linked a pull request Feb 19, 2022 that will close this issue
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants