call redirect_url on LOGIN_REDIRECT_URL #164

Merged
merged 1 commit into from Apr 12, 2015

Projects

None yet

2 participants

@drc0
Contributor
drc0 commented Mar 2, 2015

django has a standard where on LOGIN_REDIRECT_URL settings it's
permitted to use url names like 'namespace:urlname' without using
reverse_lazy on it (given it could be troublesome to import that
directly in settings), so calling redirect_url(LOGIN_REDIRECT_URL)
fixes this problem. This calling standard is also done in the
django.contrib.auth.login view, so we should follow that standard.

@drc0 drc0 call redirect_url on LOGIN_REDIRECT_URL
django has a standard where on LOGIN_REDIRECT_URL settings it's
permitted to use url names like 'namespace:urlname' without using
reverse_lazy on it (given it could be troublesome to import that
directly in settings), so calling redirect_url(LOGIN_REDIRECT_URL)
fixes this problem. This calling standard is also done in the
django.contrib.auth.login view, so we should follow that standard.
0331b92
@kennethlove kennethlove merged commit 5432bf8 into brack3t:master Apr 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment