Feature/sslrequiredmixin #171

Merged
merged 19 commits into from Apr 17, 2015

Projects

None yet

2 participants

@chrisjones-brack3t
Member

YES

SSLRequiredMixin

Addresses #108

  • New SSLRequiredMixin.
    • Redirects http -> https
    • Optionally, set view.raise_exception = True to raise a 404 instead of redirecting.
    • If DEBUG=True the SSL mixin is bypassed.
  • 100% test coverage.
  • Added Docs.
    • Updated the docs theme from default to alabaster
  • Drop support for Django 1.4. Updated tox.
  • Importing Django.VERSION instead of the whole of Django for version checking in tests.
@kennethlove kennethlove commented on an outdated diff Apr 17, 2015
docs/changelog.rst
@@ -4,6 +4,8 @@
Changelog
=========
+* :feature:`171` New SSLRequiredMixin. Redirect http -> https.
@kennethlove
kennethlove Apr 17, 2015 Member

Change SSLRequiredMixin to

:ref:`SSLRequiredMixin`
@kennethlove kennethlove commented on an outdated diff Apr 17, 2015
tests/test_access_mixins.py
@@ -1,6 +1,9 @@
# -*- coding: utf-8 -*-
from __future__ import absolute_import
+import pytest
+
+import django
@kennethlove
kennethlove Apr 17, 2015 Member

could we not just import django.VERSION instead of the whole library?

@kennethlove kennethlove merged commit 4da32df into master Apr 17, 2015
@kennethlove kennethlove deleted the feature/sslrequiredmixin branch Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment