fix SQL error in scheduled_vs_spent_time #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,7 +25,7 @@ | |||
| sql << " GROUP BY project_id, date" | |||
| sql << ") AS results" | |||
| sql << " LEFT JOIN #{Project.table_name} AS p ON p.id = results.project_id" | |||
| sql << " GROUP BY project_id" | |||
| sql << " GROUP BY p.id, p.name" | |||
There was a problem hiding this comment.
both p.id and p.name must be in the GROUP BY to allow them to be in the SELECT directly
bradbeattie
added a commit
that referenced
this pull request
Jul 6, 2011
fix SQL error in scheduled_vs_spent_time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActionView::TemplateError (PGError: ERROR: column "p.name" must appear in the GROUP BY clause or be used in an aggregate function
LINE 1: SELECT p.name, p.id, SUM(hours) AS hours, SUM(logged_hours) ...
I was tired of not seeing 'My page' anymore since I added the block from this plugin, which caused a 500
all the time. So there is a fix :P