New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression between 0.23 and 0.25 #5

Open
dormando opened this Issue Apr 27, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@dormando

dormando commented Apr 27, 2014

Hi,

A change in 0.25 kills MogileFS installs, forcing (some?) people to downgrade to 0.23:
https://groups.google.com/forum/#!searchin/mogile/read-only/mogile/2z3Ld621qUc/PbuFpY_xmAQJ

The middle mail here points to some suspicious bits. Sorry, don't have a patch or anything more specific at the moment :(

@nocode

This comment has been minimized.

Show comment
Hide comment
@nocode

nocode Sep 3, 2014

Hi, I've prepared a patch which restores old changes:

http://bogomips.org/sys-syscall.git/patch?id=9fe33d4ec79cd35b

You may also pull via:

git pull git://bogomips.org/sys-syscall.git master

(I self-host, I cannot condone/encourage GH monoculture)

Subject: restore missing changes from 0.20..0.22

Somehow the 0.25 release omitted all the following changes from
the 0.20..0.22 era. This restores the relevant changes based on
the diff between the following two tarballs:

http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Sys-Syscall-0.23.tar.gz
http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Sys-Syscall-0.25.tar.gz

Oddly, the test fix in 0.23 was preserved in 0.25, but the CHANGES
entry for 0.23 was not preserved.

0.22:

  • don't modify non-localized $_. whoops. (we don't want to mess
    with our caller's world)

0.21:

0.20:

  • on x86_64 detect 32-bit vs 64-bit process and use right syscall
    numbers. previously worked only with 64-bit userland.

nocode commented Sep 3, 2014

Hi, I've prepared a patch which restores old changes:

http://bogomips.org/sys-syscall.git/patch?id=9fe33d4ec79cd35b

You may also pull via:

git pull git://bogomips.org/sys-syscall.git master

(I self-host, I cannot condone/encourage GH monoculture)

Subject: restore missing changes from 0.20..0.22

Somehow the 0.25 release omitted all the following changes from
the 0.20..0.22 era. This restores the relevant changes based on
the diff between the following two tarballs:

http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Sys-Syscall-0.23.tar.gz
http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Sys-Syscall-0.25.tar.gz

Oddly, the test fix in 0.23 was preserved in 0.25, but the CHANGES
entry for 0.23 was not preserved.

0.22:

  • don't modify non-localized $_. whoops. (we don't want to mess
    with our caller's world)

0.21:

0.20:

  • on x86_64 detect 32-bit vs 64-bit process and use right syscall
    numbers. previously worked only with 64-bit userland.

@tsaavik

This comment has been minimized.

Show comment
Hide comment
@tsaavik

tsaavik Oct 30, 2014

+1 'Me too' post
I was able to apply the above patch to resolve my issues with sys-syscall 0.25 as provided by Ubuntu 14.04.1LTS (default repos). Thanks @nocode

tsaavik commented Oct 30, 2014

+1 'Me too' post
I was able to apply the above patch to resolve my issues with sys-syscall 0.25 as provided by Ubuntu 14.04.1LTS (default repos). Thanks @nocode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment