New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude non-PHP files from styleguide #4

Merged
merged 6 commits into from Jun 6, 2013

Conversation

Projects
None yet
2 participants
@amclin
Contributor

amclin commented Jun 5, 2013

The styleguide incorrectly searches for all files in the patterns folder when generating its display. As a result, binary files (like the .DS_Store files) are included, causing garbage on the page.

This pull request adds a filter so that only .php files are included in the styleguide display

bradfrost pushed a commit that referenced this pull request Jun 6, 2013

Brad Frost
Merge pull request #4 from amclin/master
Exclude non-PHP files from styleguide

@bradfrost bradfrost merged commit d01b41c into bradfrost:master Jun 6, 2013

@bradfrost

This comment has been minimized.

Show comment
Hide comment
@bradfrost

bradfrost Jun 6, 2013

Owner

Might need to revisit this later to keep things as language-agnostic as possible, but this should do the trick in the meantime.

Owner

bradfrost commented Jun 6, 2013

Might need to revisit this later to keep things as language-agnostic as possible, but this should do the trick in the meantime.

@amclin

This comment has been minimized.

Show comment
Hide comment
@amclin

amclin Jun 6, 2013

Contributor

This project is exciting, already using it to prototype for a client's site-wide redesign!

Contributor

amclin commented Jun 6, 2013

This project is exciting, already using it to prototype for a client's site-wide redesign!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment