New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial 'Phases' implementation finding SASS variables prefixed $bp- #6

Merged
merged 4 commits into from Jun 18, 2013

Conversation

Projects
None yet
3 participants
@benedfit
Contributor

benedfit commented Jun 7, 2013

Basic feature to traverse /css/scss folder structure and find SASS variables prefixed '$bp-', then render as a 'Phases' tab in the menu bar, using remainder of variable name and value for control e.g. $bp-small become SMALL > 24em

Basic support provided for detecting whether px or em value has been specified.

TODO:

  • Provide configuration to allow user to set pattern to match variable name on.
  • Possibly order the options based on size rather than order of declaration
  • Confirm this works with .sass as well as .scss
  • Deal with other browser units of measure
@dmolsen

This comment has been minimized.

Show comment
Hide comment
@dmolsen

dmolsen Jun 7, 2013

Collaborator

I'll let @bradfrost merge this if he feels it fits the project but it looks really cool. I saw the blog post and I'm glad you're hacking on the project. It's a really fantastic idea. I'm going to merge it with the stuff I've developed as an expansion on Brad's ideas.

Collaborator

dmolsen commented Jun 7, 2013

I'll let @bradfrost merge this if he feels it fits the project but it looks really cool. I saw the blog post and I'm glad you're hacking on the project. It's a really fantastic idea. I'm going to merge it with the stuff I've developed as an expansion on Brad's ideas.

@bradfrost

This comment has been minimized.

Show comment
Hide comment
@bradfrost

bradfrost Jun 18, 2013

Owner

I'm going to give this a shot. Seems interesting!

Owner

bradfrost commented Jun 18, 2013

I'm going to give this a shot. Seems interesting!

bradfrost pushed a commit that referenced this pull request Jun 18, 2013

Brad Frost
Merge pull request #6 from benedfit/master
Initial 'Phases' implementation finding SASS variables prefixed $bp-

@bradfrost bradfrost merged commit 9a1d940 into bradfrost:master Jun 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment