New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude .svn and .git from the pattern inc() function #8

Merged
merged 2 commits into from Jun 12, 2013

Conversation

Projects
None yet
2 participants
@amclin
Contributor

amclin commented Jun 10, 2013

This is a weird bug. On Windows systems, if this project is included in an SVN project, the inc() function will parse the cached file originals in the .svn folder instead of locally modified files. As a result, any atoms/molecules/organisms loaded through the inc() function won't display any local modifications.

This commit adds an Exclude Filter to the recursive directory scanner so that .svn and .git folders are excluded. It also makes it easier to add additional path-based filters for excluding from the inc() scanner.

@dmolsen

This comment has been minimized.

Show comment
Hide comment
@dmolsen

dmolsen Jun 11, 2013

Collaborator

I want to pull this patch locally before merging. I just want to triple-check it. Should be done this evening.

Collaborator

dmolsen commented Jun 11, 2013

I want to pull this patch locally before merging. I just want to triple-check it. Should be done this evening.

@amclin

This comment has been minimized.

Show comment
Hide comment
@amclin

amclin Jun 11, 2013

Contributor

This bug won't show up on a Mac (and presumably other Unix environments), because the inc() function is doing lazy matching to the first found result. On a Windows filesystem, .svn folder sorts before others, whereas on OSX the .svn folder will sort after regular files.

Contributor

amclin commented Jun 11, 2013

This bug won't show up on a Mac (and presumably other Unix environments), because the inc() function is doing lazy matching to the first found result. On a Windows filesystem, .svn folder sorts before others, whereas on OSX the .svn folder will sort after regular files.

dmolsen added a commit that referenced this pull request Jun 12, 2013

Merge pull request #8 from amclin/master
exclude .svn and .git from the pattern inc() function

@dmolsen dmolsen merged commit 43cf3d5 into bradfrost:master Jun 12, 2013

@amclin amclin referenced this pull request Jul 26, 2013

Closed

Annotations from a JSON File #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment