Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Until we support private repositories disable them #73

Closed
bradleyfalzon opened this issue Mar 27, 2017 · 1 comment · Fixed by #110
Closed

Until we support private repositories disable them #73

bradleyfalzon opened this issue Mar 27, 2017 · 1 comment · Fixed by #110
Assignees
@bradleyfalzon
Labels
enhancement

Comments

@bradleyfalzon
Copy link
Owner

Currently we do not support private repositories #22, but people are able to cause GopherCI to try and check them.

These clones should fail due to an unauthenticated clone, but that's not a friendly error. Additionally, soon #28 will be available and won't have authentication support (will assume everything is public), so I want to ensure private repositories are skipped.

  • In internal/github/handlers.go
  • Have PushConfig and PullRequestConfig set repository.Private bool in AnalyseConfig
  • Have Analyse check to ensure repository is not private
  • If so, SetStatus to succeeded and text stating we're skipping private repos and perhaps link to Support private repositories #22 for more details.
@bradleyfalzon bradleyfalzon mentioned this issue Apr 13, 2017
Closed
bradleyfalzon added a commit that referenced this issue Apr 24, 2017
@bradleyfalzon
Ignore GitHub events early, such as no Go repos and no installation
caa1292 
This commit sets up a better framework for ignoring certain GitHub
events early, before they're sent to the queue.

We don't queue them because some organisations have many non-Go
repositories and queuing all those jobs to just be immediately
discarded was becoming a little wasteful. In the future, I'm happy
for this decision to be reversed.

This is implemented in a GitHub specific manner, as it ensured the
events would be discarded before a clone of the repository occurred.

Resolves #80.
Related to #73.
@bradleyfalzon bradleyfalzon mentioned this issue Apr 24, 2017
Merged
bradleyfalzon added a commit that referenced this issue Apr 24, 2017
@bradleyfalzon
Ignore GitHub events early, such as no Go repos and no installation
76864d1 
This commit sets up a better framework for ignoring certain GitHub
events early, before they're sent to the queue.

We don't queue them because some organisations have many non-Go
repositories and queuing all those jobs to just be immediately
discarded was becoming a little wasteful. In the future, I'm happy
for this decision to be reversed.

This is implemented in a GitHub specific manner, as it ensured the
events would be discarded before a clone of the repository occurred.

Resolves #80.
Related to #73.
@bradleyfalzon bradleyfalzon self-assigned this Aug 8, 2017
@bradleyfalzon
Copy link
Owner Author

#80 introduced an early ignore of PRs/Pushes feature, so although I discussed implementing it in the Analyse function, I'll instead ignore them when we first receive the PR or Push Event. This will ensure no information is ever accidentally leaked by dropping the request immediately.

@bradleyfalzon bradleyfalzon mentioned this issue Aug 8, 2017
Open
bradleyfalzon added a commit that referenced this issue Aug 8, 2017
@bradleyfalzon
Ignore GitHub private repositories
4cc0d3a 
We do not currently support private repositories because we do not
use tokens to clone the repositories URLs, and the build status
pages are not currently authenticated.

This results in clone errors failing the build, and if that is fixed
could result in information leak on the build summary page.

As a stop gap, we'll ignore requests for private repositories. This
won't provide any feedback to the user, which is unfortunate, but to
do that would require a different way to ignore repositories that
provides feedback, the longer term goal is to simply support private
repositories correctly.

Fixes #73.
Relates to #22.
@bradleyfalzon bradleyfalzon mentioned this issue Aug 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradleyfalzon bradleyfalzon

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore GitHub private repositories bradleyfalzon/gopherci
1 participant
@bradleyfalzon