Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line 28, the id should be 'currencies-all' #1

Closed
cool007zqw opened this Issue Oct 17, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@cool007zqw
Copy link

cool007zqw commented Oct 17, 2017

Coinmarketcap seems to have merged assets category with currencies.

so in line 28
'assets-all' needs to be replaced by 'currencies-all'

@bradlucas

This comment has been minimized.

Copy link
Owner

bradlucas commented Oct 17, 2017

Hi,
Thanks for pointing this out. I appreciate it.

I went and checked out your suggestion and do see the table having a new id. I tried the change but noticed the script breaks not because of the suggested change but because the table has changed columns as well.

I now notice that https://coinmarketcap.com/assets/views/all/ no longer includes the platform column which is needed.

In poking around it now looks like the page originally used to develop the script is now at https://coinmarketcap.com/tokens/views/all/

Changing the script to use that url now causes it to work as before.

I've updated the repo.

Please let me know if it works for you or if you have other suggestions.

And again, thanks very much for pointing this out.

  • Brad

@bradlucas bradlucas closed this Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.