Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with example params submission #27

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@josh-works
Copy link

commented Jun 8, 2019

As outlined in #19, griddler-mailgun will fail to parse params in some situations.

We can see the expected params here:

https://github.com/bradpauly/griddler-mailgun/blob/master/lib/griddler/mailgun/adapter.rb#L15

It can be tricky, because griddler-mailgun expects a key for To, but if it receives to, it will fail to grab the param.

I'm happy to make a PR that updates the behavior of griddler-mailgun, so it's case-insensitive. I didn't want to presume too much, so I thought a quick documentation update might save someone else down the road a few hours.

This PR is at odds with #28; if this PR is accepted, #28 should be closed, and vice versa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.