Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 routing #94

Merged
merged 3 commits into from Jan 27, 2013
Merged

Rails 4 routing #94

merged 3 commits into from Jan 27, 2013

Conversation

@kstevens715
Copy link
Contributor

@kstevens715 kstevens715 commented Jan 27, 2013

This is a small fix to provide compatibility with Rails 4. I'm using get instead of match, as the routes should only accept GET requests, I believe. Thanks and thanks to @leifg as well.

@jejacks0n
Copy link
Collaborator

@jejacks0n jejacks0n commented Jan 27, 2013

As far as I'm aware this is the only change needed. Are all the assets from the engine loading correctly? I had issues with that (rails/rails#8712)

@kstevens715
Copy link
Contributor Author

@kstevens715 kstevens715 commented Jan 27, 2013

Yes, the assets appear fine. I only have an extremely basic test suite I'm using it with right now, but it works fine. This is the only change needed as far as I know too.

@jejacks0n
Copy link
Collaborator

@jejacks0n jejacks0n commented Jan 27, 2013

Thanks! I'll be merging this in shortly. =)

jejacks0n added a commit that referenced this pull request Jan 27, 2013
@jejacks0n jejacks0n merged commit 1c67956 into bradphelan:master Jan 27, 2013
@kstevens715
Copy link
Contributor Author

@kstevens715 kstevens715 commented Jan 27, 2013

Thank you for merging so fast!

@jejacks0n
Copy link
Collaborator

@jejacks0n jejacks0n commented Jan 27, 2013

It's what I'm doing with my day. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.