Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix issues with mysql2 support #26

Merged
merged 2 commits into from Mar 20, 2012

Conversation

Projects
None yet
2 participants
Contributor

BDQ commented Mar 20, 2012

The mysql / mysql2 adaptor has a few issues, I wrote a failing spec here first of all:

BDQ/apartment@38e5ce9

Which will basically bombs out with:

The adapter `mysql2` is not yet supported

The fix renames MysqlAdapter to Mysql2Adapter which I think is a better idea given the mysql gem is so out of date, I don't think it warrants ongoing support?

bradrobertson added a commit that referenced this pull request Mar 20, 2012

Merge pull request #26 from BDQ/mysql2
Fix issues with mysql2 support

@bradrobertson bradrobertson merged commit 0b678f5 into bradrobertson:development Mar 20, 2012

Owner

bradrobertson commented Mar 20, 2012

do you need a release for this right away? I was hoping to look further into the test suite for the next release, but I can do a patch release if you need.

Contributor

BDQ commented Mar 20, 2012

No rush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment