New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETCoreApp 1.0 #65

Closed
nfdevil opened this Issue Aug 4, 2016 · 7 comments

Comments

Projects
None yet
3 participants
@nfdevil

nfdevil commented Aug 4, 2016

Are there any plans to porting this to support framework NETCoreApp 1.0.0?

@bradymholt

This comment has been minimized.

Show comment
Hide comment
@bradymholt

bradymholt Aug 4, 2016

Owner

Absolutely. I'm working on it.

Owner

bradymholt commented Aug 4, 2016

Absolutely. I'm working on it.

@bradymholt

This comment has been minimized.

Show comment
Hide comment
@bradymholt

bradymholt Aug 4, 2016

Owner

.NET Portability Report

image

Owner

bradymholt commented Aug 4, 2016

.NET Portability Report

image

@bradymholt

This comment has been minimized.

Show comment
Hide comment
@bradymholt

bradymholt Aug 4, 2016

Owner

I could surely use a hand with getting this library working on .NET Core. Even some initial guidance and recommendations on the approach to take would be great.

It looks like, at the very least, we are going to need to rework some of the i18n support as .NET Core does not support the CurrentCulture properties.

Also, I am not sure if we should try to get the existing NuGet package to be multi platform or if we should just cut ties and create a new .NET Core compatible library that is not backwards compatible with the existing one. I am leaning in this direction.

Owner

bradymholt commented Aug 4, 2016

I could surely use a hand with getting this library working on .NET Core. Even some initial guidance and recommendations on the approach to take would be great.

It looks like, at the very least, we are going to need to rework some of the i18n support as .NET Core does not support the CurrentCulture properties.

Also, I am not sure if we should try to get the existing NuGet package to be multi platform or if we should just cut ties and create a new .NET Core compatible library that is not backwards compatible with the existing one. I am leaning in this direction.

@nfdevil

This comment has been minimized.

Show comment
Hide comment
@nfdevil

nfdevil Aug 4, 2016

Indeed, and because .NET core doesn't support currentculture, why don't you let the consumer of your library set a culture property als configuration (with possibility to override this configuration with a setter like SetCurrentLocale(string locale = "en-US") ) which changes the current culture info. Because for my example I'll be using this in an ASP.NET core application, which gets the culture from either the browsersetting or a culture chosen by the user.

nfdevil commented Aug 4, 2016

Indeed, and because .NET core doesn't support currentculture, why don't you let the consumer of your library set a culture property als configuration (with possibility to override this configuration with a setter like SetCurrentLocale(string locale = "en-US") ) which changes the current culture info. Because for my example I'll be using this in an ASP.NET core application, which gets the culture from either the browsersetting or a culture chosen by the user.

@bradymholt

This comment has been minimized.

Show comment
Hide comment
@bradymholt

bradymholt Aug 5, 2016

Owner

I've got PR #66 with the work started to port over. I'll add related comments there.

Owner

bradymholt commented Aug 5, 2016

I've got PR #66 with the work started to port over. I'll add related comments there.

@martingagne

This comment has been minimized.

Show comment
Hide comment
@martingagne

martingagne Jul 5, 2017

Hello @bradyholt! Any update on this? Were you able to complete the port?

martingagne commented Jul 5, 2017

Hello @bradyholt! Any update on this? Were you able to complete the port?

@bradymholt

This comment has been minimized.

Show comment
Hide comment
@bradymholt

bradymholt Aug 10, 2017

Owner

Very close! PR close to merging: #66

Owner

bradymholt commented Aug 10, 2017

Very close! PR close to merging: #66

@bradymholt bradymholt closed this in #66 Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment