Removed deactivation alterations of Jetpack #2

Merged
merged 1 commit into from Dec 3, 2013

Projects

None yet

2 participants

@blobaugh
Contributor
blobaugh commented Dec 3, 2013

Howdy Brady! Saw your mention on WP Tavern ( http://www.wptavern.com/easier-way-to-enable-or-disable-jetpack-modules-with-rocketeer ). Love the plugin! Thanks a ton for building it. I did notice that you blew away Jetpack's deactivation and put your own in place of it. What is the thought process that you had for that? In general it is not recommended to remove Jetpack's deactivation process as it is doing far more than you may think. There is a lot of cleanup that happens under the hood both with your site and on WordPress.com. This pull request restores that functionality.

I find it interesting that you put the Heartbeat stuff in your deactivate. That was a good catch. I just noticed myself last week that the disconnect was put in an awkward location inside of Jetpack and moved it to the deactivate method. You should see that in a future release.

@blobaugh blobaugh Removed deactivation alterations of Jetpack
Not allowing Jetpack to go through its own deactivation sequence is not recommended. There is cleanup that Jetpack and WordPress.com need to do, including turning off services on the WordPress.com side that will repeatedly hit your server.

I did notice in Jetpack the Heartbeat removal is in a strange location and have corrected that already to be part of the deactivation sequence. You should see it in an upcoming release, thus also rendering your Heartbeat disconnect irrelevant.
3c85eb8
@bradyvercher bradyvercher merged commit 6e5a2d3 into bradyvercher:master Dec 3, 2013
@bradyvercher
Owner

Hey Ben, thanks for the update. I mainly started this as a proof of concept to change a few things I didn't like and the disconnection on deactivation was one of them. I don't think that part ever worked and understand how it could cause issues for others, so I'm happy to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment