This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

#3797 Fix "Unix Makefile" build on macOS

  • Loading branch information...
rishubil authored and Andrew Nelless committed Oct 28, 2014
1 parent 2b9f486 commit d1396c976727779accd7a7bac1bc61d8e154abfa
Showing with 7 additions and 5 deletions.
  1. +7 −5 ext/toolchain/commands1.py
View
@@ -430,14 +430,16 @@ def configureCore(self, target="", extraArgs=""):
if generator.cmakeName.find('Unix Makefiles') != -1:
cmake_args += ' -DCMAKE_BUILD_TYPE=' + target.capitalize()
- elif sys.platform == "darwin":
+ if sys.platform == "darwin":
macSdkMatch = re.match("(\d+)\.(\d+)", self.macSdk)
if not macSdkMatch:
raise Exception("unknown osx version: " + self.macSdk)
- sdkDir = self.getMacSdkDir()
- cmake_args += " -DCMAKE_OSX_SYSROOT=" + sdkDir
- cmake_args += " -DCMAKE_OSX_DEPLOYMENT_TARGET=" + self.macSdk
+ if generator.cmakeName.find('Unix Makefiles') == -1:
+ sdkDir = self.getMacSdkDir()
+ cmake_args += " -DCMAKE_OSX_SYSROOT=" + sdkDir
+ cmake_args += " -DCMAKE_OSX_DEPLOYMENT_TARGET=" + self.macSdk
+
cmake_args += " -DOSX_TARGET_MAJOR=" + macSdkMatch.group(1)
cmake_args += " -DOSX_TARGET_MINOR=" + macSdkMatch.group(2)
@@ -551,7 +553,7 @@ def getMacSdkDir(self):
if os.path.exists(sdkPath):
return sdkPath
- return "/Developer/SDKs/" + sdkDirName + ".sdk"
+ return os.popen('xcodebuild -version -sdk macosx' + self.macSdk + ' Path').read().strip()
# http://tinyurl.com/cs2rxxb
def fixCmakeEclipseBug(self):

0 comments on commit d1396c9

Please sign in to comment.