brahma-dev/synergy-stable-builds forked from symless/synergy-core
Comparing changes
Open a pull request
move deletion of accepted client socket pointers to ClientListener
where it belongs. previously SecureListenSocket would delete the client socket but TCPListenSocket would not. PacketStreamFilter would then attempt to delete the socket regardless of what type it was. this would cause an access violation when SecureListenSocket attempted to delete the socket again. fixes #3
pass QS_POSTMESSAGE to GetQueueStatus() instead of QS_ALLINPUT.
QS_ALLINPUT is a meta-flag that includes QS_POINTER and QS_TOUCH, both of which can cause GetQueueStatus() to return 0 even when there are pending messages. fixes #4
disable check for updated version since it was causing an access
violation on close and since there is nothing to check it against anyway. will reimplement check for updated version in the future.
double-clicking tray icon should work on windows as well. also labele…
…d the tray icon with a tooltip.
when running barriers/barrierc inside a windows debugger, add a pause
before exiting so the output in the terminal window can be read
changed SettingsDialog layout to group options more reasonably
added checkbox for minimizing to tray don't hide "hide on startup" on windows
use a relatively small hack to keep barriers/barrierc from crashing on
unixes when they are killed from the GUI with QProcess's close(). the stdin stream is going completely unused (though the stdout stream is not) so use stdin to send a shutdown command. this solution avoids all the nastiness and overhead of using shared memory, mutexes, condvars, etc. just to communicate "stop" from one process to another
implement "Immune Keys" which are keys that are ignored by
server-to-client key-forwarding. this feature is only implemented for servers running on windows machines.
rmdir doesn't set errorlevel but mkdir does and can be used to check …
…for errors up to that point...to a point
fix installer build. at this point the process is not at all robust..…
…it mainly just works for me.
revert some of the "deprecated" fixes so that older OSX versions are …
…still supported. my thanks to Cpuroast for additional macos testing.
moved SSL configuration on OSX from Library/Barrier to Library/Applic…
…ation Support/Barrier as per the App Programming Guide. fixes #5 ref: https://developer.apple.com/library/content/documentation/General/Conceptual/MOSXAppProgrammingGuide/AppRuntime/AppRuntime.html
migrate k/m hook handlers from synwinhk to platform/MSWindowsHook and…
… delete synwinhk.dll. for ever and ever.
clean up AppConfig; eliminate unnecessary UI changes to MainWindow; M…
…ainWindow starts at smaller size
re-add Hide to menu because not all WMs will add a minimize button to…
… the title bar; add WM hint so that tiling WMs might float it instead
link gui with common; reimplement finding personal and profile direct…
…ories on windows (not yet used)
reimplement ArchFile*::getSystemDirectory() as DataDirectories::syste…
…mconfig(). windows will now use ProgramData by default rather than C:\Windows
reimplement path operations basename() and concat() in Common. these …
…were the last bits remaining in ArchFile* so it was removed
server should look for config in the profile() dir rather than the pe…
…rsonal() dir. removed personal() since it is no longer used.
remove dangling handler..fixes race condition when a clipboard event …
…is queued but not dispatched before disconnect
Merge pull request #26 from debauchee/nosyntool
Drop syntool. In the process some platform-dependent locations have changed. Some users may need to recreate config files or copy the from the old location(s).
fix ipv6 handling between GUI and barriers/barrierc; zero-fill sockad…
…dr_in(6) structs prior to initializing; update --help output
| @@ -1,13 +0,0 @@ | ||
| -"Instructions | ||
| -"Download vim script 411 | ||
| -"http://www.vim.org/scripts/script.php?script_id=441 | ||
| -"Install localvimrc.vim to .vim/plugin | ||
| -" | ||
| -" Hint: You can disable it asking before sourcing a file by adding this to | ||
| -" your .vimrc: let g:localvimrc_ask=0 | ||
| - | ||
| -set nosmarttab | ||
| -set noexpandtab | ||
| -set shiftwidth=8 | ||
| -set softtabstop=0 | ||
| -set tabstop=4 |
| @@ -0,0 +1,10 @@ | ||
| +language: cpp | ||
| +before_install: | ||
| +- sudo apt-get update -qq | ||
| +- sudo apt-get install -qq libxtst-dev | ||
| +- sudo apt-get install -qq qtdeclarative5-dev | ||
| +- sudo apt-get install -qq libavahi-compat-libdnssd-dev | ||
| +script: sh -x ./clean_build.sh | ||
| +# skip install phase since we have a customized install package | ||
| +# creation tool for each supported platform | ||
| +install: true |
| @@ -0,0 +1,7 @@ | ||
| +# | ||
| +# Barrier build parameters | ||
| +# | ||
| +BARRIER_VERSION_MAJOR = 1 | ||
| +BARRIER_VERSION_MINOR = 9 | ||
| +BARRIER_VERSION_PATCH = 0 | ||
| +BARRIER_VERSION_STAGE = snapshot |
Showing you all comments on commits in this comparison.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
walker0643
commented on be0fab1
Feb 24, 2018
|
fixes #8 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
kloetzl
Mar 17, 2018
As you are already touching src/lib/barrier/ServerApp.cpp:123-157 you could also really improve the code by not writing into a static char buffer and instead use the mechanics for building strings C++ gives you. At the least you should use snprintf or asprintf. Same goes for the client app.
kloetzl
commented on 63a7936
Mar 17, 2018
|
As you are already touching |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
walker0643
Mar 17, 2018
Agreed, it's really horrible. I do try not to let my OCD talk me into modifying otherwise working production code just because it's ugly...but I think we'll let this be an exception, shall we? :)
walker0643
commented on 63a7936
Mar 17, 2018
|
Agreed, it's really horrible. I do try not to let my OCD talk me into modifying otherwise working production code just because it's ugly...but I think we'll let this be an exception, shall we? :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
walker0643
commented on 63a7936
Mar 17, 2018
|
I hope you find this more to your liking. |
fixes #8