Comparing changes
Open a pull request
| @@ -1,13 +0,0 @@ | ||
| -"Instructions | ||
| -"Download vim script 411 | ||
| -"http://www.vim.org/scripts/script.php?script_id=441 | ||
| -"Install localvimrc.vim to .vim/plugin | ||
| -" | ||
| -" Hint: You can disable it asking before sourcing a file by adding this to | ||
| -" your .vimrc: let g:localvimrc_ask=0 | ||
| - | ||
| -set nosmarttab | ||
| -set noexpandtab | ||
| -set shiftwidth=8 | ||
| -set softtabstop=0 | ||
| -set tabstop=4 |
| @@ -0,0 +1,7 @@ | ||
| +# | ||
| +# Synergy build parameters | ||
| +# | ||
| +SYNERGY_VERSION_MAJOR = 2 | ||
| +SYNERGY_VERSION_MINOR = 0 | ||
| +SYNERGY_VERSION_PATCH = 10 | ||
| +SYNERGY_VERSION_STAGE = snapshot |
Showing you all comments on commits in this comparison.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
epakai
commented on 513f50a
Apr 25, 2017
•
edited
Edited 1 time
-
epakai
edited Apr 25, 2017
edited
-
Apr 25, 2017
|
I noted the disclaimer in debian/copyright about including closed source components. As far as I knew synergy was completely open source (at least for all the libraries necessary for linux operation). Is this expected to change for 1.9/2.0 releases? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
The 256? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Yeah. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
nlyan
May 4, 2017
Contributor
It's a trivial bitmask op so no. Perhaps change it to "|= 0xFF", but I don't tend to do that in simple cases because it's easy to mistype/miscount the number the number of Fs
|
It's a trivial bitmask op so no. Perhaps change it to "|= 0xFF", but I don't tend to do that in simple cases because it's easy to mistype/miscount the number the number of Fs |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
So what does 256 actually mean in this context? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
nlyan
May 4, 2017
Contributor
Modulo 256 is the same as masking off all but the last 8 bits. Although replacing the int ('c') with an unsigned char, instead of an unsigned int, would make this unnecessary, it wouldnt work with the stringstream. std::ostream derived classes behave differently to chars than to integers.
Here's a demo http://cpp.sh/6ubuc (click Run)
Test 1 shows the problem we had (excessive FFs being put in to the serial key)
Test 2 shows the new behaviour
Test 3 (commented out) will cause the cpp.sh website to have a bad time if you uncomment it. If run locally it will simply ignore your request for hexadecimal and output raw bytes
|
Modulo 256 is the same as masking off all but the last 8 bits. Although replacing the int ('c') with an unsigned char, instead of an unsigned int, would make this unnecessary, it wouldnt work with the stringstream. std::ostream derived classes behave differently to chars than to integers. Here's a demo http://cpp.sh/6ubuc (click Run) Test 1 shows the problem we had (excessive FFs being put in to the serial key) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
This was a nasty bug right here... |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
(lParam & 0x40000000u) == 1 is always false |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
This overloads rather than overrides the base class |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
This overloads rather than overrides the base class |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
liyang
Jul 24, 2017
The ‘closed source component’ probably refers to the GUI. I imagine synergyc & synergys is not part of this.
liyang
commented on 513f50a
Jul 24, 2017
|
The ‘closed source component’ probably refers to the GUI. I imagine |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
yupi2
commented on 9da6974
Dec 11, 2017
|
RESOURSES is a typo - might be the correct variable in your build setup though |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
3onyc
Dec 12, 2017
Has this been replaced with on-by-default TLS or is there something else going on?
3onyc
commented on 4b3adfc
Dec 12, 2017
|
Has this been replaced with on-by-default TLS or is there something else going on? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
nlyan
commented on 9da6974
Dec 18, 2017
•
edited
Edited 1 time
-
nlyan
edited Dec 18, 2017
edited
-
Dec 18, 2017
|
It is (valid in our build env)... thanks for pointing it out. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
3onyc
Dec 18, 2017
So Symless finally relented and gave non-pro users encryption, only to take it away again later :/
Anyway, for people still using synergy-core, you can use stunnel and still get TLS
3onyc
commented on 4b3adfc
Dec 18, 2017
|
So Symless finally relented and gave non-pro users encryption, only to take it away again later :/ Anyway, for people still using synergy-core, you can use stunnel and still get TLS |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
daef
commented on f720d62
Apr 16, 2018
|
This link redirects me to a login without registration form - is it of any use? |
I noted the disclaimer in debian/copyright about including closed source components. As far as I knew synergy was completely open source (at least for all the libraries necessary for linux operation). Is this expected to change for 1.9/2.0 releases?