New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query txns metadata #90

merged 37 commits into from Jan 20, 2017


None yet
1 participant

jamesnvc commented Dec 31, 2016

Builds on #89

Refactors the remaining functions that needed to call d/transact! because they needed the return value; now, a datom can have metadata that run-txns! will use to make return values.

jamesnvc added some commits Dec 20, 2016

Remove unused function threads-with-tag
I believe this functionality has been subsumed by the search functions
Make most db transactions return datoms
Instead of directly mutating the database, instead return vectors of
transactions to be applied.  Not all functions have been converted yet,
as some rely on either getting the return value or doing multiple
independent transactions.  WIP.
Make db sub-nses require db to get conn
Since db isn't require'ing all the db.* namespaces, they can now import
db to get access to db/conn, instead of the caller having to do it all
over the place
Make user-set-preference-txn compose properly
Because it now may be running in a transaction with other datoms, it
needs to have a unique tempid
Make create-user! return a txn vector + metadata
Part of refactor to remove last few transactions that return a result by
letting `run-txns!` return stuff based on metadata set on the txn
Refactor most other uses of create-entity!
create-messages! yet to be converted
Refactor create-message! to new style
Only update-thread-last-open! remains...

This comment has been minimized.

Show comment
Hide comment

jamesnvc Jan 9, 2017


@rafd are you okay with this one?


jamesnvc commented Jan 9, 2017

@rafd are you okay with this one?

@jamesnvc jamesnvc merged commit 8d0a109 into master Jan 20, 2017

1 check passed

continuous-integration/codeship Build succeeded

@jamesnvc jamesnvc deleted the query-txns-metadata branch Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment