Submission modules #180
Merged
Submission modules #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model scoring with a plug repo in mechanism
mschrimpf
requested changes
Jan 9, 2020
There was a problem hiding this comment.
high-level comments
- cool!
- I find the similar sounding methods in
submission/__init.py,score_model.pyconfusing. Suggestion: Movescore_modelmethod tobrainscore/__init__.py, renamescore_model.pytosubmission/__init__.py - there's some mixing of coding styles:
os.pathvspathliband string-formatting vs f-strings - the manual file-writing could be made more robust with pandas I think
- the manual db-writing could be made more robust with an ORM library
- is there a way for us to unit-test parts of this? e.g. by mocking jenkins and the database away and asserting that the right things are written?
|
@mschrimpf : I've worked through your comments. I don't think an ORM is necessary. I only have one insert statement so this should be fine as it is. Also I didn't add the code to |
|
OK everything looks good except the argument list in https://github.com/brain-score/brain-score/pull/180/files#diff-e76a4ede37cda5bffaf698022bbf6f24R85 which should either use keyword-arguments or a dict with the arguments as we talked about. |
mschrimpf
approved these changes
Jan 10, 2020
|
great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains code to allow model submissions by delivering a zip file or git repository.
The modules unpack and run the submitted models and automatically save the results to the configured database.