Improve splitting of datasets #147
Conversation
|
would you ming add some test @gemeinl ? can this be illustrated in some documentation / example? |
Not at all. I added an example as well as some tests. |
braindecode/datasets/base.py
Outdated
| @@ -109,34 +109,37 @@ def __init__(self, list_of_ds): | |||
| super().__init__(list_of_ds) | |||
| self.description = pd.DataFrame([ds.description for ds in list_of_ds]) | |||
|
|
|||
| def split(self, some_property=None, split_ids=None): | |||
| """Split the dataset based on some property listed in its description | |||
| def split(self, by): | |||
There was a problem hiding this comment.
technically you are breaking public API here again. Maybe we want to reach a proper version
before stabilizing API. I feel there are still many moving parts.
There was a problem hiding this comment.
My bad, I am not yet used to deprecating and not breaking the API. And yes, a lot of stuff is moving.
There was a problem hiding this comment.
@gemeinl if you care about the design of the API it's great. Don't worry for now about breaking API as long as it's for the best.
| # | ||
| # License: BSD (3-clause) | ||
|
|
||
| from IPython.display import display |
There was a problem hiding this comment.
why do you need this?
adding a dependency on ipython to do a print seems an overkill to me.
There was a problem hiding this comment.
I just copied it from examples.plot_dataset_example.py, so the dependency was already there. Could of course remove it everywhere.
|
I just copied it from examples.plot_dataset_example.py, so the dependency was already there. Could of course remove it everywhere.
I would do this. Maybe in another PR if you want
|
gemeinl
force-pushed
the
improve_split
branch
from
0a0f984
to
67d09a5
Compare
…of integers, or a list of list of integers. will now always return a dictionary with string keys
…ced new argument 'by'.
-fixed splitting tests
gemeinl
force-pushed
the
improve_split
branch
from
67d09a5
to
8a107fb
Compare
split()now has a single argumentbywhich ca be a string, a list of integers, or a list of list of integers.splitting now always returns a dictionary with string keys.