-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Adding support for on-the-fly transforms #198
[MRG] Adding support for on-the-fly transforms #198
Conversation
It was brought to my attention that the discussion on #177 leaned toward using the With this in mind, do we want to also include a simpler |
Sorry @sbbrandt I meant to ask here haha: |
But based on extensive previous discussion (thanks for linking @hubertjb ) I would also say this way could be merged already. and then batch level we can add separately at a later point. |
@robintibor Yes, makes more sense ;) This implementation is also nice and works for many DA methods. E.g. mixup would need another implementation, but can still be implemented via a custom |
Can you rebase this on current master to see if CIs run @hubertjb ? For example in my setup steps would be:
|
565702d
to
77907a6
Compare
…aseConcatDataset to enable on-the-fly transforms - updating docstrings - adding test
77907a6
to
0c5e62d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just would like to know answer, then we can merge
Ok I applied the changes then, also because I felt curious how Github UI works for this hihi @hubertjb |
Ok great, Github Actions succeeded, so merging! :) Thanks for the work |
This PR adds support for on-the-fly transforms in
BaseDataset
andWindowsDataset
. It also adds a similar API to modify the underlying transforms inBaseConcatDataset
.It is based on the way transforms are implemented in torchvision: https://pytorch.org/tutorials/beginner/data_loading_tutorial.html