[WIP] Added a confusion matrix plot generator. #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vytjan
changed the title
|
because ours much more beautiful! ;) See discussion end of #242 so it was considered ! But I would try to add the class names in the example |
|
We agreed that we can keep like this (with own function that shows a bit more information than scikitlearn) depending on how strong @agramfort objects to it :D |
|
I won't strongly object I am just more lazy than you ;)
… |
robintibor
reviewed
Jun 25, 2021
robintibor
reviewed
Jun 25, 2021
| confusion_mat = confusion_matrix(y_true, y_pred) | ||
|
|
||
| # add class labels | ||
| label_dict = valid_set.datasets[0].windows.event_id.items() |
There was a problem hiding this comment.
Suggested change
| label_dict = valid_set.datasets[0].windows.event_id.items() | |
| # label_dict is class_name : str -> i_class : int | |
| label_dict = valid_set.datasets[0].windows.event_id.items() |
robintibor
reviewed
Jun 25, 2021
|
And maybe just add same code also for trialwise example, why not? |
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refering to #242
@Ann-KathrinKiessner @dcwil @HenrikBons