[MRG] Fixing serialization of SleepPhysionet #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etween ch_names and _orig_units - adding tests
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 80.51% 80.51%
=======================================
Files 49 49
Lines 3171 3171
=======================================
Hits 2553 2553
Misses 618 618 |
hubertjb
changed the title
robintibor
approved these changes
Sep 9, 2021
|
great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two minor bugs with the SleepPhysionet class that I came across with while running some tests for #325. First, the
excludeattribute of the Raw object was adict_keysobject, which prevented the dataset from being serialized. Second, channels were renamed usingmne.rename_channelsinstead of using Raw'srename_channelsmethod, which led to.ch_namesand._orig_unitshaving different channel names. This created an issue when applying the filterbank preprocessor.