[MRG] Parse callbacks on yield #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome @robintibor I like it, I even started implementing this on my side few minutes ago! Just add maybe the test of cloning from #340 :) |
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 81.23% 81.70% +0.47%
==========================================
Files 51 51
Lines 3453 3455 +2
==========================================
+ Hits 2805 2823 +18
+ Misses 648 632 -16 |
|
great @sliwy added the test and actually found a small copy-paste-bug :) |
robintibor
changed the title
|
🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is another way to solve #340
It passed tests locally, let's see if its all good