Parameters of MOABB datasets #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
- Coverage 81.90% 81.85% -0.05%
==========================================
Files 51 51
Lines 3515 3517 +2
==========================================
Hits 2879 2879
- Misses 636 638 +2 |
|
@agramfort I just fixed the style errors |
robintibor
reviewed
Nov 28, 2021
braindecode/datasets/moabb.py
Outdated
|
|
||
| dataset_kwargs: dict, optional | ||
| optional dictionary containing keyword arguments | ||
| to pass to the moabb dataset when instanciating it. |
There was a problem hiding this comment.
Is instantiate or instanciate correct spelling?
|
thanks looks good, just wonder about one small spelling thing |
|
Thanks you're right, it's instantiating. I fixed it
Le 28/11/2021 à 22:00, robintibor a écrit :
…
thanks looks good, just wonder about one small spelling thing
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#365 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGCZSJLN5IRP7X4EM24RXHDUOKJ5NANCNFSM5I5L6QIQ>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
agramfort
approved these changes
Nov 29, 2021
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
|
@robintibor @gemeinl merge if happy thx @PierreGtch |
|
Great thanks @PierreGtch merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #364